From 049024bbb2b08836d39e183e10d8fea76e0a422a Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Mon, 27 Mar 2023 12:29:30 +0200 Subject: [PATCH] tests/config/test_config_sid: Mark tasks as noqa 503 The latest ansible-lint failes for the tasks that are using "when: sid_disabled.changed" with the error "Tasks that run when changed should likely be handlers.". As these tasks are tests and it would not make sense to use handlers here, the tasks have been marked as noqa 503. --- tests/config/test_config_sid.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/config/test_config_sid.yml b/tests/config/test_config_sid.yml index cd3ce4fb..fdae1fba 100644 --- a/tests/config/test_config_sid.yml +++ b/tests/config/test_config_sid.yml @@ -30,7 +30,7 @@ check_mode: yes register: sid_disabled - - name: Ensure netbios_name can't be changed without SID enabled. + - name: Ensure netbios_name can't be changed without SID enabled. # noqa 503 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -39,7 +39,7 @@ failed_when: not result.failed and "SID generation must be enabled" in result.msg when: sid_disabled.changed - - name: Ensure SIDs can't be changed without SID enabled. + - name: Ensure SIDs can't be changed without SID enabled. # noqa 503 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" -- GitLab