From 0782e260f24e3f03f9ff98f89e3fdeb5fc59113c Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Thu, 26 Nov 2020 18:13:14 -0300
Subject: [PATCH] Fix ansible-lint E208 by setting file modes in file and copy
 tasks.

---
 molecule/resources/playbooks/prepare.yml                         | 1 +
 roles/ipaserver/tasks/copy_external_cert.yml                     | 1 +
 tests/ca-less/install_replica_without_ca.yml                     | 1 +
 tests/ca-less/install_server_without_ca.yml                      | 1 +
 .../install-server-with-external-ca-with-manual-copy.yml         | 1 +
 tests/vault/env_setup.yml                                        | 1 +
 6 files changed, 6 insertions(+)

diff --git a/molecule/resources/playbooks/prepare.yml b/molecule/resources/playbooks/prepare.yml
index 26d139e4..761d4a95 100644
--- a/molecule/resources/playbooks/prepare.yml
+++ b/molecule/resources/playbooks/prepare.yml
@@ -16,6 +16,7 @@
       owner: dirsrv
       group: dirsrv
       path: "{{ item }}"
+      mode: 0770
     loop:
       - /var/lock/dirsrv/
       - /var/lock/dirsrv/slapd-TEST-LOCAL/
diff --git a/roles/ipaserver/tasks/copy_external_cert.yml b/roles/ipaserver/tasks/copy_external_cert.yml
index 2d394a96..84eee236 100644
--- a/roles/ipaserver/tasks/copy_external_cert.yml
+++ b/roles/ipaserver/tasks/copy_external_cert.yml
@@ -6,6 +6,7 @@
   copy:
     src: "{{ item }}"
     dest: "/root/{{ item | basename }}"
+    mode: preserve
     force: yes
 - name: Install - Extend ipaserver_external_cert_files with "/root/{{ item | basename }}"
   set_fact:
diff --git a/tests/ca-less/install_replica_without_ca.yml b/tests/ca-less/install_replica_without_ca.yml
index 83398b24..dc026220 100644
--- a/tests/ca-less/install_replica_without_ca.yml
+++ b/tests/ca-less/install_replica_without_ca.yml
@@ -48,6 +48,7 @@
       file:
         path: "/root/ca-less-test"
         state: directory
+        mode: 0775
 
     - name: Copy CA certificate
       copy:
diff --git a/tests/ca-less/install_server_without_ca.yml b/tests/ca-less/install_server_without_ca.yml
index ecb609c4..add0f622 100644
--- a/tests/ca-less/install_server_without_ca.yml
+++ b/tests/ca-less/install_server_without_ca.yml
@@ -48,6 +48,7 @@
       file:
         path: "/root/ca-less-test"
         state: directory
+        mode: 0775
 
     - name: Copy CA certificate
       copy:
diff --git a/tests/external-signed-ca-with-manual-copy/install-server-with-external-ca-with-manual-copy.yml b/tests/external-signed-ca-with-manual-copy/install-server-with-external-ca-with-manual-copy.yml
index 19cea6b8..9ab763bd 100644
--- a/tests/external-signed-ca-with-manual-copy/install-server-with-external-ca-with-manual-copy.yml
+++ b/tests/external-signed-ca-with-manual-copy/install-server-with-external-ca-with-manual-copy.yml
@@ -42,6 +42,7 @@
       src: "{{ groups.ipaserver[0] + '-chain.crt' }}"
       dest: "/root/chain.crt"
       force: yes
+      mode: preserve
 
   roles:
   - role: ipaserver
diff --git a/tests/vault/env_setup.yml b/tests/vault/env_setup.yml
index 4e2d40e8..69e9cb71 100644
--- a/tests/vault/env_setup.yml
+++ b/tests/vault/env_setup.yml
@@ -20,6 +20,7 @@
     copy:
       src: "{{ playbook_dir }}/{{ item }}"
       dest: "{{ ansible_facts['env'].HOME }}/{{ item }}"
+      mode: 0644
     with_items:
     - A_private.pem
     - A_public.pem
-- 
GitLab