From 089400dbd0ed8c7788e7fc74a93841714eeb2c6a Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Thu, 30 Sep 2021 21:14:36 -0300
Subject: [PATCH] dnszone: Use IPAAnsibleModule method to validate arguments.
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
---
plugins/modules/ipadnszone.py | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/plugins/modules/ipadnszone.py b/plugins/modules/ipadnszone.py
index 30ceef27..c1354d3a 100644
--- a/plugins/modules/ipadnszone.py
+++ b/plugins/modules/ipadnszone.py
@@ -429,13 +429,10 @@ class DNSZoneModule(FreeIPABaseModule):
self.fail_json(
msg="Either `name` or `name_from_ip` must be provided."
)
- if self.ipa_params.state != "present" and self.ipa_params.name_from_ip:
- self.fail_json(
- msg=(
- "Cannot use argument `name_from_ip` with state `%s`."
- % self.ipa_params.state
- )
- )
+ if self.ipa_params.state != "present":
+ invalid = ["name_from_ip"]
+
+ self.params_fail_used_invalid(invalid, self.ipa_params.state)
def define_ipa_commands(self):
for zone_name in self.get_zone_names():
--
GitLab