From 0af208d271cc8dba1097f0acfc475696ec18f3af Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Tue, 23 Nov 2021 13:17:21 +0100 Subject: [PATCH] Replace asserts with raise AssertionError This patch is needed to pass Automation Hub tests. --- plugins/modules/ipaservice.py | 3 ++- roles/ipaclient/library/ipaclient_get_facts.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/modules/ipaservice.py b/plugins/modules/ipaservice.py index 5c4363d8..79ab96c7 100644 --- a/plugins/modules/ipaservice.py +++ b/plugins/modules/ipaservice.py @@ -288,7 +288,8 @@ def gen_args_smb(netbiosname, ok_as_delegate, ok_to_auth_as_delegate): def check_parameters(module, state, action, names, parameters): - assert isinstance(parameters, dict) + if not isinstance(parameters, dict): + raise AssertionError("parameters is not a dict") # invalid parameters for everything but state 'present', action 'service'. invalid = ['pac_type', 'auth_ind', 'skip_host_check', diff --git a/roles/ipaclient/library/ipaclient_get_facts.py b/roles/ipaclient/library/ipaclient_get_facts.py index 09fe7e84..be5e79d7 100644 --- a/roles/ipaclient/library/ipaclient_get_facts.py +++ b/roles/ipaclient/library/ipaclient_get_facts.py @@ -84,7 +84,8 @@ def is_dogtag_configured(subsystem): # ca / kra is configured when the directory # /var/lib/pki/pki-tomcat/[ca|kra] # exists available_subsystems = {'ca', 'kra'} - assert subsystem in available_subsystems + if subsystem not in available_subsystems: + raise AssertionError("Subsystem '%s' not available" % subsystem) return os.path.isdir(os.path.join(VAR_LIB_PKI_TOMCAT, subsystem)) -- GitLab