From 18c195b052e35a7ef391c4ba457b5ea486ffd564 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Wed, 9 Dec 2020 15:57:42 +0100
Subject: [PATCH] utils/new_module: Fix covscan findings
warning[SC2166]: Prefer [ p ] || [ q ] as [ p -o q ] is not well
defined.
---
utils/new_module | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/new_module b/utils/new_module
index 8253e4f4..b6eecb27 100755
--- a/utils/new_module
+++ b/utils/new_module
@@ -73,7 +73,7 @@ author=$2
email=$3
year=$(date +"%Y")
-if [ -z "$name" -o -z "$author" -o -z "$email" ]; then
+if [ -z "$name" ] || [ -z "$author" ] || [ -z "$email" ]; then
[ -z "$name" ] && echo "ERROR: name is not valid"
[ -z "$author" ] && echo "ERROR: author is not valid"
[ -z "$email" ] && echo "ERROR: email is not valid"
--
GitLab