diff --git a/plugins/module_utils/ansible_freeipa_module.py b/plugins/module_utils/ansible_freeipa_module.py index 338e0f7c0c825caedcb761ffa71ee48460b5188a..a18a89f79f36676fc11b34948dc61211d0a4f82c 100644 --- a/plugins/module_utils/ansible_freeipa_module.py +++ b/plugins/module_utils/ansible_freeipa_module.py @@ -294,16 +294,8 @@ else: # If both args and ipa are None, return there's no difference. # If only one is None, return there is a difference. # This tests avoid unecessary invalid access to attributes. - if args is None and ipa is None: - return True if args is None or ipa is None: - module.debug( - base_debug_msg + "args is%s None an ipa is%s None" % ( - "" if args is None else " not", - "" if ipa is None else " not", - ) - ) - return False + return args is None and ipa is None # Fail if args or ipa are not dicts. if not (isinstance(args, dict) and isinstance(ipa, dict)): diff --git a/plugins/modules/ipadnszone.py b/plugins/modules/ipadnszone.py index 07b1df81e402d031dbc94393ecb2afdcc3258198..ae8ed93ad5da2172123df2f194b4347db9d2c520 100644 --- a/plugins/modules/ipadnszone.py +++ b/plugins/modules/ipadnszone.py @@ -269,16 +269,12 @@ class DNSZoneModule(FreeIPABaseModule): except ValueError: return False - if not all([part1.isdigit(), part2.isdigit(), part3.isdigit()]): - return False - - if not 0 <= int(part1) <= 255: - return False - - if not 0 <= int(part2) <= 255: - return False - - if not 0 <= int(part3) <= 65535: + if ( + not all([part1.isdigit(), part2.isdigit(), part3.isdigit()]) + or not 0 <= int(part1) <= 255 + or not 0 <= int(part2) <= 255 + or not 0 <= int(part3) <= 65535 + ): return False try: