From 29d565e3d2856d49942e9e531d6dc8d51678285b Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:17 +0200
Subject: [PATCH] test_hbacrule_categories.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/hbacrule/test_hbacrule_categories.yml | 24 ++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/hbacrule/test_hbacrule_categories.yml b/tests/hbacrule/test_hbacrule_categories.yml
index 67bc9934..f2110955 100644
--- a/tests/hbacrule/test_hbacrule_categories.yml
+++ b/tests/hbacrule/test_hbacrule_categories.yml
@@ -19,7 +19,7 @@
name: testrule
usercategory: all
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with usercategory 'all', again.
ipahbacrule:
@@ -27,7 +27,7 @@
name: testrule
usercategory: all
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC rule is present, with no usercategory.
ipahbacrule:
@@ -35,7 +35,7 @@
name: testrule
usercategory: ""
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with no usercategory, again.
ipahbacrule:
@@ -43,7 +43,7 @@
name: testrule
usercategory: ""
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC rule is present, with hostcategory 'all'
ipahbacrule:
@@ -51,7 +51,7 @@
name: testrule
hostcategory: all
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with hostcategory 'all', again.
ipahbacrule:
@@ -59,7 +59,7 @@
name: testrule
hostcategory: all
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC rule is present, with no hostcategory.
ipahbacrule:
@@ -67,7 +67,7 @@
name: testrule
hostcategory: ""
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with no hostcategory, again.
ipahbacrule:
@@ -75,7 +75,7 @@
name: testrule
hostcategory: ""
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC rule is present, with servicecategory 'all'
ipahbacrule:
@@ -83,7 +83,7 @@
name: testrule
servicecategory: all
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with servicecategory 'all', again.
ipahbacrule:
@@ -91,7 +91,7 @@
name: testrule
servicecategory: all
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC rule is present, with no servicecategory.
ipahbacrule:
@@ -99,7 +99,7 @@
name: testrule
servicecategory: ""
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC rule is present, with no servicecategory, again.
ipahbacrule:
@@ -107,7 +107,7 @@
name: testrule
servicecategory: ""
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure `user` cannot be added if usercategory is `all`.
ipahbacrule:
--
GitLab