From 2c37580cec4ac93b3ce0c46bc747026121efee8c Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:24 +0200
Subject: [PATCH] test_host_managedby_host.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/host/test_host_managedby_host.yml | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/tests/host/test_host_managedby_host.yml b/tests/host/test_host_managedby_host.yml
index 81fccbd6..a96b674f 100644
--- a/tests/host/test_host_managedby_host.yml
+++ b/tests/host/test_host_managedby_host.yml
@@ -29,7 +29,7 @@
name: "{{ host1_fqdn }}"
force: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host2_fqdn }}" present
ipahost:
@@ -37,7 +37,7 @@
name: "{{ host2_fqdn }}"
force: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" managed by "{{ 'host2.' + ipaserver_domain }}"
ipahost:
@@ -45,7 +45,7 @@
name: "{{ host1_fqdn }}"
managedby_host: "{{ host2_fqdn }}"
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" managed by "{{ 'host2.' + ipaserver_domain }}" again
ipahost:
@@ -53,7 +53,7 @@
name: "{{ host1_fqdn }}"
managedby_host: "{{ host2_fqdn }}"
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host "{{ host1_fqdn }}" managed by "{{ ansible_facts['fqdn'] }}"
ipahost:
@@ -62,7 +62,7 @@
managedby_host: "{{ ansible_facts['fqdn'] }}"
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" managed by "{{ ansible_facts['fqdn'] }}" again
ipahost:
@@ -71,7 +71,7 @@
managedby_host: "{{ ansible_facts['fqdn'] }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host "{{ host1_fqdn }}" not managed by "{{ ansible_facts['fqdn'] }}"
ipahost:
@@ -81,7 +81,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" not managed by "{{ ansible_facts['fqdn'] }}" again
ipahost:
@@ -91,7 +91,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host "{{ host1_fqdn }}" not managed by "{{ 'host2.' + ipaserver_domain }}"
ipahost:
@@ -101,7 +101,7 @@
state: absent
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" not managed by "{{ 'host2.' + ipaserver_domain }}" again
ipahost:
@@ -111,7 +111,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host absent
ipahost:
@@ -122,4 +122,4 @@
update_dns: yes
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
--
GitLab