From 3147f31226774d35106394c0d6f3b4aba747b0db Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Thu, 20 May 2021 18:28:19 +0200 Subject: [PATCH] user: Fix no modifications to be performed error The no_members parameter is added to args for the api command. But no_members is never part of res_find from user-show, therefore this parameter needs to be ignored in compare_args_ipa. This is needed to prevent an error in the idempotency test where a user is ensured again with the same settings. --- plugins/modules/ipauser.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/plugins/modules/ipauser.py b/plugins/modules/ipauser.py index 52463abb..3657a626 100644 --- a/plugins/modules/ipauser.py +++ b/plugins/modules/ipauser.py @@ -1115,8 +1115,13 @@ def main(): # For all settings is args, check if there are # different settings in the find result. # If yes: modify - if not compare_args_ipa(ansible_module, args, - res_find): + # The nomembers parameter is added to args for the + # api command. But no_members is never part of + # res_find from user-show, therefore this parameter + # needs to be ignored in compare_args_ipa. + if not compare_args_ipa( + ansible_module, args, res_find, + ignore=["no_members"]): commands.append([name, "user_mod", args]) else: -- GitLab