From 3c357a2f0716f9f03f026b11fde096f137034def Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 12:29:45 +0200
Subject: [PATCH] test_dnsforwardzone.yml: Add failed_when and repeated tests
One task is missing the verification of the test result, some other
tasks are not repeated to verify idempotency.
---
tests/dnsforwardzone/test_dnsforwardzone.yml | 44 ++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/tests/dnsforwardzone/test_dnsforwardzone.yml b/tests/dnsforwardzone/test_dnsforwardzone.yml
index 223cf3d0..372bbbec 100644
--- a/tests/dnsforwardzone/test_dnsforwardzone.yml
+++ b/tests/dnsforwardzone/test_dnsforwardzone.yml
@@ -127,6 +127,16 @@
ipaadmin_password: SomeADMINpassword
name: example.com
state: absent
+ register: result
+ failed_when: not result.changed or result.failed
+
+ - name: ensure forwardzone example.com is absent, again.
+ ipadnsforwardzone:
+ ipaadmin_password: SomeADMINpassword
+ name: example.com
+ state: absent
+ register: result
+ failed_when: result.changed or result.failed
- name: ensure forwardzone example.com is created with minimal args
ipadnsforwardzone:
@@ -139,6 +149,17 @@
register: result
failed_when: not result.changed
+ - name: ensure forwardzone example.com is created with minimal args, again
+ ipadnsforwardzone:
+ ipaadmin_password: SomeADMINpassword
+ state: present
+ name: example.com
+ skip_overlap_check: true
+ forwarders:
+ - ip_address: 8.8.8.8
+ register: result
+ failed_when: result.changed or result.failed
+
- name: add a forwarder to any existing ones
ipadnsforwardzone:
ipaadmin_password: SomeADMINpassword
@@ -151,6 +172,18 @@
register: result
failed_when: not result.changed
+ - name: add a forwarder to any existing ones, again
+ ipadnsforwardzone:
+ ipaadmin_password: SomeADMINpassword
+ state: present
+ name: example.com
+ forwarders:
+ - ip_address: 4.4.4.4
+ port: 8053
+ action: member
+ register: result
+ failed_when: result.changed or result.failed
+
- name: check the list of forwarders is what we expect
ipadnsforwardzone:
ipaadmin_password: SomeADMINpassword
@@ -175,6 +208,17 @@
register: result
failed_when: not result.changed
+ - name: remove a single forwarder, again
+ ipadnsforwardzone:
+ ipaadmin_password: SomeADMINpassword
+ state: absent
+ name: example.com
+ forwarders:
+ - ip_address: 8.8.8.8
+ action: member
+ register: result
+ failed_when: result.changed or result.failed
+
- name: check the list of forwarders is what we expect now
ipadnsforwardzone:
ipaadmin_password: SomeADMINpassword
--
GitLab