From 3d436677a5f6dfa8887a003ef0c35c3e09e64b79 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:11 +0200
Subject: [PATCH] test_dnsrecord_full_records.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
.../dnsrecord/test_dnsrecord_full_records.yml | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tests/dnsrecord/test_dnsrecord_full_records.yml b/tests/dnsrecord/test_dnsrecord_full_records.yml
index 86e124c8..cd703d13 100644
--- a/tests/dnsrecord/test_dnsrecord_full_records.yml
+++ b/tests/dnsrecord/test_dnsrecord_full_records.yml
@@ -18,7 +18,7 @@
zone_name: "{{ testzone }}"
a_rec: 192.168.122.101
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns A record for 'host01' is present, again
ipadnsrecord:
@@ -27,7 +27,7 @@
zone_name: "{{ testzone }}"
a_rec: 192.168.122.101
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure that dns A records for 'host01' are present
ipadnsrecord:
@@ -39,7 +39,7 @@
- 192.168.122.102
- 192.168.122.103
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns A records for 'host01' are present, again
ipadnsrecord:
@@ -51,7 +51,7 @@
- 192.168.122.102
- 192.168.122.103
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure that dns A records for 'host01' are absent
ipadnsrecord:
@@ -63,7 +63,7 @@
- 192.168.122.102
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns A records for 'host01' are absent, again
ipadnsrecord:
@@ -75,7 +75,7 @@
- 192.168.122.102
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
####
@@ -86,7 +86,7 @@
zone_name: "{{ testzone }}"
aaaa_rec: fd00::0001
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns AAAA record for 'host01' is present, again
ipadnsrecord:
@@ -95,7 +95,7 @@
zone_name: "{{ testzone }}"
aaaa_rec: fd00::0001
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure that dns AAAA records for 'host01' are present
ipadnsrecord:
@@ -107,7 +107,7 @@
- fd00::0011
- fd00::0021
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns AAAAA records for 'host01' are present, again
ipadnsrecord:
@@ -119,7 +119,7 @@
- fd00::0011
- fd00::0021
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure that dns AAAAA records for 'host01' are absent
ipadnsrecord:
@@ -131,7 +131,7 @@
- fd00::0011
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure that dns AAAAA records for 'host01' are absent, again
ipadnsrecord:
@@ -143,7 +143,7 @@
- fd00::0011
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
# Cleanup
- name: Cleanup test environment.
--
GitLab