From 3de6f9146e3f17fb4f9b3f512a925341af348584 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 12 Oct 2023 13:51:13 +0200
Subject: [PATCH] hbacsvcgroup: Remove obsolete result_handler
The result_handler is not needed anymore as the idempotency issues with
members have been fixed already for this module.
Related: #685 hbacsvcgroup: Fix member management idempotence issues.
---
plugins/modules/ipahbacsvcgroup.py | 18 ++----------------
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/plugins/modules/ipahbacsvcgroup.py b/plugins/modules/ipahbacsvcgroup.py
index ea4766d1..09b4d74d 100644
--- a/plugins/modules/ipahbacsvcgroup.py
+++ b/plugins/modules/ipahbacsvcgroup.py
@@ -146,21 +146,6 @@ def gen_member_args(hbacsvc):
return _args
-# pylint: disable=unused-argument
-def result_handler(module, result, command, name, args, errors):
- # Get all errors
- # All "already a member" and "not a member" failures in the
- # result are ignored. All others are reported.
- if "failed" in result and "member" in result["failed"]:
- failed = result["failed"]["member"]
- for member_type in failed:
- for member, failure in failed[member_type]:
- if "already a member" not in failure \
- and "not a member" not in failure:
- errors.append("%s: %s %s: %s" % (
- command, member_type, member, failure))
-
-
def main():
ansible_module = IPAAnsibleModule(
argument_spec=dict(
@@ -303,7 +288,8 @@ def main():
}])
# Execute commands
- changed = ansible_module.execute_ipa_commands(commands, result_handler)
+ changed = ansible_module.execute_ipa_commands(
+ commands, fail_on_member_errors=True)
# Done
--
GitLab