From 414dc06c860850fc66dcd20f63c74febbc52121d Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Tue, 17 Jan 2023 12:53:02 +0100 Subject: [PATCH] ansible-lint: All names should start with an uppercase letter --- .../config/set-ca-renewal-master-server.yml | 2 +- playbooks/dnszone/dnszone-all-params.yml | 2 +- playbooks/dnszone/dnszone-present.yml | 2 +- playbooks/trust/add-trust.yml | 2 +- playbooks/trust/del-trust.yml | 2 +- tests/automount/test_automountkey.yml | 32 +++--- tests/automount/test_automountlocation.yml | 22 ++-- tests/automount/test_automountmap.yml | 36 +++--- tests/backup_role/test_backup.yml | 8 +- tests/config/test_config.yml | 104 +++++++++--------- tests/dnsforwardzone/test_dnsforwardzone.yml | 58 +++++----- tests/group/test_group_external_members.yml | 2 +- tests/trust/test_trust.yml | 2 +- 13 files changed, 137 insertions(+), 137 deletions(-) diff --git a/playbooks/config/set-ca-renewal-master-server.yml b/playbooks/config/set-ca-renewal-master-server.yml index 5e0a1e6a..f8187a46 100644 --- a/playbooks/config/set-ca-renewal-master-server.yml +++ b/playbooks/config/set-ca-renewal-master-server.yml @@ -5,7 +5,7 @@ gather_facts: no tasks: - - name: set ca_renewal_master_server + - name: Set ca_renewal_master_server ipaconfig: ipaadmin_password: SomeADMINpassword ca_renewal_master_server: carenewal.example.com diff --git a/playbooks/dnszone/dnszone-all-params.yml b/playbooks/dnszone/dnszone-all-params.yml index 79747d2a..5cba47f8 100644 --- a/playbooks/dnszone/dnszone-all-params.yml +++ b/playbooks/dnszone/dnszone-all-params.yml @@ -1,5 +1,5 @@ --- -- name: dnszone present +- name: All dnszone parameters hosts: ipaserver become: true diff --git a/playbooks/dnszone/dnszone-present.yml b/playbooks/dnszone/dnszone-present.yml index 04d07ba0..9cbeff8e 100644 --- a/playbooks/dnszone/dnszone-present.yml +++ b/playbooks/dnszone/dnszone-present.yml @@ -1,5 +1,5 @@ --- -- name: dnszone present +- name: Dnszone present hosts: ipaserver become: true diff --git a/playbooks/trust/add-trust.yml b/playbooks/trust/add-trust.yml index 9842939a..83b09fe6 100644 --- a/playbooks/trust/add-trust.yml +++ b/playbooks/trust/add-trust.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: ensure the trust is present + - name: Ensure the trust is present ipatrust: ipaadmin_password: SomeADMINpassword realm: windows.local diff --git a/playbooks/trust/del-trust.yml b/playbooks/trust/del-trust.yml index 0d0f95f1..2a27d972 100644 --- a/playbooks/trust/del-trust.yml +++ b/playbooks/trust/del-trust.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: ensure the trust is absent + - name: Ensure the trust is absent ipatrust: ipaadmin_password: SomeADMINpassword realm: windows.local diff --git a/tests/automount/test_automountkey.yml b/tests/automount/test_automountkey.yml index 27ebf30e..a36ef322 100644 --- a/tests/automount/test_automountkey.yml +++ b/tests/automount/test_automountkey.yml @@ -5,18 +5,18 @@ gather_facts: no tasks: - - name: ensure test location TestLocation is present + - name: Ensure test location TestLocation is present ipaautomountlocation: ipaadmin_password: SomeADMINpassword name: TestLocation - - name: ensure test map TestMap is present + - name: Ensure test map TestMap is present ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap location: TestLocation - - name: ensure key NewKeyName is absent + - name: Ensure key NewKeyName is absent ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -24,7 +24,7 @@ key: NewKeyName state: absent - - name: ensure key TestKey is absent + - name: Ensure key TestKey is absent ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -35,7 +35,7 @@ - name: Execute Automount Key tests block: ### test the key creation, and modification - - name: ensure key TestKey is present + - name: Ensure key TestKey is present ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -46,7 +46,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure key TestKey is present again + - name: Ensure key TestKey is present again ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -58,7 +58,7 @@ failed_when: result.failed or result.changed ## modify the key - - name: ensure key TestKey information has been updated + - name: Ensure key TestKey information has been updated ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -69,7 +69,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure key TestKey information has been updated again + - name: Ensure key TestKey information has been updated again ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -81,7 +81,7 @@ failed_when: result.failed or result.changed ## modify the name - - name: ensure key TestKey has been renamed to NewKeyName + - name: Ensure key TestKey has been renamed to NewKeyName ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -92,7 +92,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure key TestKey is absent + - name: Ensure key TestKey is absent ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -102,7 +102,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure key NewKeyName is present + - name: Ensure key NewKeyName is present ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -113,7 +113,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure failure when state is renamed and newname is not set + - name: Ensure failure when state is renamed and newname is not set ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -125,7 +125,7 @@ ### cleanup after the tests always: - - name: ensure key NewKeyName is absent + - name: Ensure key NewKeyName is absent ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -133,7 +133,7 @@ key: NewKeyName state: absent - - name: ensure key TestKey is absent + - name: Ensure key TestKey is absent ipaautomountkey: ipaadmin_password: SomeADMINpassword location: TestLocation @@ -141,14 +141,14 @@ key: NewKeyName state: absent - - name: ensure map TestMap is absent + - name: Ensure map TestMap is absent ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap location: TestLocation state: absent - - name: ensure location TestLocation is absent + - name: Ensure location TestLocation is absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword name: TestLocation diff --git a/tests/automount/test_automountlocation.yml b/tests/automount/test_automountlocation.yml index 7e6c3abb..8e652447 100644 --- a/tests/automount/test_automountlocation.yml +++ b/tests/automount/test_automountlocation.yml @@ -5,7 +5,7 @@ gather_facts: false tasks: - - name: ensure automountlocation TestLocations are absent before testing + - name: Ensure automountlocation TestLocations are absent before testing ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -14,7 +14,7 @@ - TestLocation_02 state: absent - - name: ensure empty automountlocation does nothing + - name: Ensure empty automountlocation does nothing ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -23,7 +23,7 @@ register: result failed_when: not result.failed or "At least one location must be provided" not in result.msg - - name: ensure empty automountlocation does nothing on absent + - name: Ensure empty automountlocation does nothing on absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -32,7 +32,7 @@ register: result failed_when: not result.failed or "At least one location must be provided" not in result.msg - - name: ensure automountlocation TestLocation is present + - name: Ensure automountlocation TestLocation is present ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -41,7 +41,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure automountlocation TestLocation is present again + - name: Ensure automountlocation TestLocation is present again ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -50,7 +50,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure automountlocation TestLocation is absent + - name: Ensure automountlocation TestLocation is absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -59,7 +59,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure automountlocation TestLocation is absent again + - name: Ensure automountlocation TestLocation is absent again ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -68,7 +68,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure a list of automountlocations are present + - name: Ensure a list of automountlocations are present ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -79,7 +79,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure a list of automountlocations exist + - name: Ensure a list of automountlocations exist ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -90,7 +90,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure a list of automountlocations are absent + - name: Ensure a list of automountlocations are absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -101,7 +101,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure multiple automountlocations are absent + - name: Ensure multiple automountlocations are absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" diff --git a/tests/automount/test_automountmap.yml b/tests/automount/test_automountmap.yml index 417c9fd4..1fc72acc 100644 --- a/tests/automount/test_automountmap.yml +++ b/tests/automount/test_automountmap.yml @@ -6,7 +6,7 @@ tasks: # setup environment - - name: ensure test maps are absent + - name: Ensure test maps are absent ipaautomountmap: ipaadmin_password: SomeADMINpassword name: @@ -15,20 +15,20 @@ location: TestLocation state: absent - - name: ensure location TestLocation is absent + - name: Ensure location TestLocation is absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword name: TestLocation state: absent - - name: ensure map TestMap is absent + - name: Ensure map TestMap is absent ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap location: TestLocation state: absent - - name: ensure location TestLocation is present + - name: Ensure location TestLocation is present ipaautomountlocation: ipaadmin_password: SomeADMINpassword name: TestLocation @@ -37,7 +37,7 @@ # TESTS - name: Execute Automount Map tests block: - - name: ensure map TestMap is present + - name: Ensure map TestMap is present ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -46,7 +46,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure map TestMap is present again + - name: Ensure map TestMap is present again ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -54,7 +54,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure map TestMap has a different description + - name: Ensure map TestMap has a different description ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -63,7 +63,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure map TestMap has a different description, again + - name: Ensure map TestMap has a different description, again ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -72,7 +72,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure map TestMap has an empty description + - name: Ensure map TestMap has an empty description ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -81,7 +81,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure map TestMap has an empty description, again + - name: Ensure map TestMap has an empty description, again ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -90,7 +90,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure map TestMap is removed + - name: Ensure map TestMap is removed ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -99,7 +99,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure map TestMap has been removed + - name: Ensure map TestMap has been removed ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap @@ -108,7 +108,7 @@ register: result failed_when: result.failed or result.changed - - name: ensure map TestMap01 is present + - name: Ensure map TestMap01 is present ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap01 @@ -117,7 +117,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure map TestMap02 is present + - name: Ensure map TestMap02 is present ipaautomountmap: ipaadmin_password: SomeADMINpassword name: TestMap02 @@ -126,7 +126,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure TestMap01 and TestMap02 are both absent + - name: Ensure TestMap01 and TestMap02 are both absent ipaautomountmap: ipaadmin_password: SomeADMINpassword name: @@ -137,7 +137,7 @@ register: result failed_when: result.failed or not result.changed - - name: ensure TestMap01 and TestMap02 are both absent again + - name: Ensure TestMap01 and TestMap02 are both absent again ipaautomountmap: ipaadmin_password: SomeADMINpassword name: @@ -150,7 +150,7 @@ # CLEAN UP always: - - name: ensure test maps are absent + - name: Ensure test maps are absent ipaautomountmap: ipaadmin_password: SomeADMINpassword name: @@ -159,7 +159,7 @@ location: TestLocation state: absent - - name: ensure location TestLocation is absent + - name: Ensure location TestLocation is absent ipaautomountlocation: ipaadmin_password: SomeADMINpassword name: TestLocation diff --git a/tests/backup_role/test_backup.yml b/tests/backup_role/test_backup.yml index 9f68656f..9bcefa1b 100644 --- a/tests/backup_role/test_backup.yml +++ b/tests/backup_role/test_backup.yml @@ -174,7 +174,7 @@ become: no # Copy all backups from server - - name: list all existing backups on server + - name: List all existing backups on server ansible.builtin.find: path: /var/lib/ipa/backup recurse: no @@ -305,7 +305,7 @@ become: no # Remove all backups from server - - name: list all existing backups on server + - name: List all existing backups on server ansible.builtin.find: path: /var/lib/ipa/backup recurse: no @@ -320,7 +320,7 @@ state: absent ipabackup_name: all - - name: list all existing backups on server + - name: List all existing backups on server ansible.builtin.find: path: /var/lib/ipa/backup recurse: no @@ -342,7 +342,7 @@ state: absent ipabackup_name: all - - name: list all existing backups on server + - name: List all existing backups on server ansible.builtin.find: path: /var/lib/ipa/backup recurse: no diff --git a/tests/config/test_config.yml b/tests/config/test_config.yml index 8cadafba..ced34211 100644 --- a/tests/config/test_config.yml +++ b/tests/config/test_config.yml @@ -11,7 +11,7 @@ - name: Execute config tests block: # Retrieve current configuration. - - name: return current values of the global configuration options + - name: Return current values of the global configuration options ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -22,7 +22,7 @@ var: previousconfig # setup environment. - - name: create test group + - name: Create test group ipagroup: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -34,25 +34,25 @@ ipaapi_context: "{{ ipa_context | default(omit) }}" emaildomain: ipa.test - - name: set default shell to '/bin/sh' + - name: Set default shell to '/bin/sh' ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" defaultshell: /bin/sh - - name: set default group + - name: Set default group ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" defaultgroup: ipausers - - name: set default home directory + - name: Set default home directory ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" homedirectory: /home - - name: clear pac-type + - name: Clear pac-type ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -60,68 +60,68 @@ - name: Execute tests if ipa_version >= 4.8.0 block: - - name: set maxhostname to 255 + - name: Set maxhostname to 255 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" maxhostname: 255 when: ipa_version is version('4.8.0', '>=') - - name: set maxusername to 45 + - name: Set maxusername to 45 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" maxusername: 45 - - name: set pwdexpnotify to 0 + - name: Set pwdexpnotify to 0 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" pwdexpnotify: 0 - - name: set searchrecordslimit to 10 + - name: Set searchrecordslimit to 10 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" searchrecordslimit: 10 - - name: set searchtimelimit to 1 + - name: Set searchtimelimit to 1 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" searchtimelimit: 1 - - name: clear configstring + - name: Clear configstring ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" configstring: "" - - name: set configstring to AllowNThash + - name: Set configstring to AllowNThash ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" configstring: 'KDC:Disable Lockout' - - name: set selinuxusermapdefault + - name: Set selinuxusermapdefault ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" selinuxusermapdefault: "staff_u:s0-s0:c0.c1023" - - name: set selinuxusermaporder + - name: Set selinuxusermaporder ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023' - - name: set usersearch to `uid` + - name: Set usersearch to `uid` ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" usersearch: uid - - name: set groupsearch to `cn` + - name: Set groupsearch to `cn` ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -144,7 +144,7 @@ register: result failed_when: result.changed or result.failed - - name: set default shell to '/bin/someshell' + - name: Set default shell to '/bin/someshell' ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -152,7 +152,7 @@ register: result failed_when: not result.changed or result.failed - - name: set default shell to '/bin/someshell', again. + - name: Set default shell to '/bin/someshell', again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -160,7 +160,7 @@ register: result failed_when: result.changed or result.failed - - name: set default group + - name: Set default group ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -168,7 +168,7 @@ register: result failed_when: not result.changed or result.failed - - name: set default group, again + - name: Set default group, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -176,7 +176,7 @@ register: result failed_when: result.changed or result.failed - - name: set default home directory + - name: Set default home directory ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -184,7 +184,7 @@ register: result failed_when: not result.changed or result.failed - - name: set default home directory, again + - name: Set default home directory, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -192,7 +192,7 @@ register: result failed_when: result.changed or result.failed - - name: set pac-type + - name: Set pac-type ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -200,7 +200,7 @@ register: result failed_when: not result.changed or result.failed - - name: set pac-type, again. + - name: Set pac-type, again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -208,7 +208,7 @@ register: result failed_when: result.changed or result.failed - - name: set maxusername to 33 + - name: Set maxusername to 33 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -216,7 +216,7 @@ register: result failed_when: not result.changed or result.failed - - name: set maxusername to 33, again. + - name: Set maxusername to 33, again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -226,7 +226,7 @@ - name: Execute tests if ipa_version >= 4.8.0 block: - - name: set maxhostname to 77 + - name: Set maxhostname to 77 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -234,7 +234,7 @@ register: result failed_when: not result.changed or result.failed - - name: set maxhostname to 77, again + - name: Set maxhostname to 77, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -243,7 +243,7 @@ failed_when: result.changed or result.failed when: ipa_version is version('4.8.0', '>=') - - name: set pwdexpnotify to 17 + - name: Set pwdexpnotify to 17 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -251,7 +251,7 @@ register: result failed_when: not result.changed or result.failed - - name: set pwdexpnotify to 17, again + - name: Set pwdexpnotify to 17, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -259,7 +259,7 @@ register: result failed_when: result.changed or result.failed - - name: set searchrecordslimit to -1 + - name: Set searchrecordslimit to -1 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -267,7 +267,7 @@ register: result failed_when: not result.changed or result.failed - - name: set searchrecordslimit to -1, again. + - name: Set searchrecordslimit to -1, again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -275,7 +275,7 @@ register: result failed_when: result.changed or result.failed - - name: set searchtimelimit to 12345 + - name: Set searchtimelimit to 12345 ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -283,7 +283,7 @@ register: result failed_when: not result.changed or result.failed - - name: set searchtimelimit to 12345, again. + - name: Set searchtimelimit to 12345, again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -291,7 +291,7 @@ register: result failed_when: result.changed or result.failed - - name: change enable_migration + - name: Change enable_migration ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -299,7 +299,7 @@ register: result failed_when: not result.changed or result.failed - - name: change enable_migration, again + - name: Change enable_migration, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -307,7 +307,7 @@ register: result failed_when: result.changed or result.failed - - name: set configstring to AllowNThash + - name: Set configstring to AllowNThash ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -315,7 +315,7 @@ register: result failed_when: not result.changed or result.failed - - name: set configstring to AllowNThash, again. + - name: Set configstring to AllowNThash, again. ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -323,7 +323,7 @@ register: result failed_when: result.changed or result.failed - - name: set selinuxusermaporder + - name: Set selinuxusermaporder ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -331,7 +331,7 @@ register: result failed_when: not result.changed or result.failed - - name: set selinuxusermaporder, again + - name: Set selinuxusermaporder, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -339,7 +339,7 @@ register: result failed_when: result.changed or result.failed - - name: set selinuxusermapdefault + - name: Set selinuxusermapdefault ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -347,7 +347,7 @@ register: result failed_when: not result.changed or result.failed - - name: set selinuxusermapdefault, again + - name: Set selinuxusermapdefault, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -355,7 +355,7 @@ register: result failed_when: result.changed or result.failed - - name: set groupsearch to `description` + - name: Set groupsearch to `description` ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -363,7 +363,7 @@ register: result failed_when: not result.changed or result.failed - - name: set groupsearch to `gidNumber`, again + - name: Set groupsearch to `gidNumber`, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -371,7 +371,7 @@ register: result failed_when: result.changed or result.failed - - name: set usersearch to `uidNumber` + - name: Set usersearch to `uidNumber` ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -379,7 +379,7 @@ register: result failed_when: not result.changed or result.failed - - name: set usersearch to `uidNumber`, again + - name: Set usersearch to `uidNumber`, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -387,7 +387,7 @@ register: result failed_when: result.changed or result.failed - - name: reset changed fields + - name: Reset changed fields ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -416,14 +416,14 @@ - name: Execute tests if ipa_version >= 4.8.0 block: - - name: reset maxhostname + - name: Reset maxhostname ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" maxhostname: '{{ previousconfig.config.maxhostname | default(omit) }}' when: ipa_version is version('4.8.0', '>=') - - name: reset changed fields, again + - name: Reset changed fields, again ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -452,7 +452,7 @@ - name: Execute tests if ipa_version >= 4.8.0 block: - - name: reset maxhostname + - name: Reset maxhostname ipaconfig: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -492,7 +492,7 @@ always: # cleanup - - name: cleanup test group + - name: Cleanup test group ipagroup: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" diff --git a/tests/dnsforwardzone/test_dnsforwardzone.yml b/tests/dnsforwardzone/test_dnsforwardzone.yml index 260829ff..43c0f141 100644 --- a/tests/dnsforwardzone/test_dnsforwardzone.yml +++ b/tests/dnsforwardzone/test_dnsforwardzone.yml @@ -5,7 +5,7 @@ gather_facts: false tasks: - - name: ensure test forwardzones are absent + - name: Ensure test forwardzones are absent ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -14,7 +14,7 @@ - newfailzone.com state: absent - - name: ensure forwardzone example.com is created + - name: Ensure forwardzone example.com is created ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -27,7 +27,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure forwardzone example.com is present again + - name: Ensure forwardzone example.com is present again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -40,7 +40,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure forwardzone example.com has two forwarders + - name: Ensure forwardzone example.com has two forwarders ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -55,7 +55,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure forwardzone example.com has one forwarder again + - name: Ensure forwardzone example.com has one forwarder again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -68,7 +68,7 @@ register: result failed_when: result.changed or result.failed - - name: skip_overlap_check can only be set on creation so change nothing + - name: Skip_overlap_check can only be set on creation so change nothing ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -81,7 +81,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure forwardzone example.com is absent. + - name: Ensure forwardzone example.com is absent. ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -90,7 +90,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure forwardzone example.com is absent, again. + - name: Ensure forwardzone example.com is absent, again. ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -99,7 +99,7 @@ register: result failed_when: result.changed or result.failed - - name: change all the things at once + - name: Change all the things at once ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -115,7 +115,7 @@ register: result failed_when: not result.changed or result.failed - - name: change zone forward policy + - name: Change zone forward policy ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -124,7 +124,7 @@ register: result failed_when: not result.changed or result.failed - - name: change zone forward policy, again + - name: Change zone forward policy, again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -133,7 +133,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure forwardzone example.com is absent. + - name: Ensure forwardzone example.com is absent. ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -142,7 +142,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure forwardzone example.com is absent, again. + - name: Ensure forwardzone example.com is absent, again. ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -151,7 +151,7 @@ register: result failed_when: result.changed or result.failed - - name: ensure forwardzone example.com is created with minimal args + - name: Ensure forwardzone example.com is created with minimal args ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -163,7 +163,7 @@ register: result failed_when: not result.changed or result.failed - - name: ensure forwardzone example.com is created with minimal args, again + - name: Ensure forwardzone example.com is created with minimal args, again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -175,7 +175,7 @@ register: result failed_when: result.changed or result.failed - - name: add a forwarder to any existing ones + - name: Add a forwarder to any existing ones ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -188,7 +188,7 @@ register: result failed_when: not result.changed or result.failed - - name: add a forwarder to any existing ones, again + - name: Add a forwarder to any existing ones, again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -201,7 +201,7 @@ register: result failed_when: result.changed or result.failed - - name: check the list of forwarders is what we expect + - name: Check the list of forwarders is what we expect ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -215,7 +215,7 @@ register: result failed_when: result.changed or result.failed - - name: remove a single forwarder + - name: Remove a single forwarder ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -227,7 +227,7 @@ register: result failed_when: not result.changed or result.failed - - name: remove a single forwarder, again + - name: Remove a single forwarder, again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -239,7 +239,7 @@ register: result failed_when: result.changed or result.failed - - name: check the list of forwarders is what we expect now + - name: Check the list of forwarders is what we expect now ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -292,7 +292,7 @@ register: result failed_when: result.changed or result.failed - - name: disable the forwarder + - name: Disable the forwarder ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -301,7 +301,7 @@ register: result failed_when: not result.changed or result.failed - - name: disable the forwarder again + - name: Disable the forwarder again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -310,7 +310,7 @@ register: result failed_when: result.changed or result.failed - - name: enable the forwarder + - name: Enable the forwarder ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -319,7 +319,7 @@ register: result failed_when: not result.changed or result.failed - - name: enable the forwarder, again + - name: Enable the forwarder, again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -328,14 +328,14 @@ register: result failed_when: result.changed or result.failed - - name: ensure forwardzone example.com is absent again + - name: Ensure forwardzone example.com is absent again ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" name: example.com state: absent - - name: try to create a new forwarder with action=member + - name: Try to create a new forwarder with action=member ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -349,7 +349,7 @@ register: result failed_when: not result.failed or "not found" not in result.msg - - name: try to create a new forwarder with disabled state + - name: Try to create a new forwarder with disabled state ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" @@ -366,7 +366,7 @@ register: result failed_when: not result.failed or "No forwarders specified" not in result.msg - - name: ensure forwardzone example.com is absent - tidy up + - name: Ensure forwardzone example.com is absent - tidy up ipadnsforwardzone: ipaadmin_password: SomeADMINpassword ipaapi_context: "{{ ipa_context | default(omit) }}" diff --git a/tests/group/test_group_external_members.yml b/tests/group/test_group_external_members.yml index 559408a8..db926cf4 100644 --- a/tests/group/test_group_external_members.yml +++ b/tests/group/test_group_external_members.yml @@ -1,5 +1,5 @@ --- -- name: find trust +- name: Find trust hosts: ipaserver become: true gather_facts: false diff --git a/tests/trust/test_trust.yml b/tests/trust/test_trust.yml index 2bf236f1..e0e63386 100644 --- a/tests/trust/test_trust.yml +++ b/tests/trust/test_trust.yml @@ -48,7 +48,7 @@ register: result failed_when: result.failed or not result.changed - - name: check if 'ipa-ad-trust' trust exists + - name: Check if 'ipa-ad-trust' trust exists ansible.builtin.shell: | echo 'SomeADMINpassword' | kinit admin ipa trust-find -- GitLab