From 41940304daeff4f57644e407e184bf3cbefb48f6 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:27 +0200
Subject: [PATCH] test_host_reverse.yml: Use result.failed also for failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/host/test_host_reverse.yml | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/host/test_host_reverse.yml b/tests/host/test_host_reverse.yml
index 36a0abcc..8e5e337e 100644
--- a/tests/host/test_host_reverse.yml
+++ b/tests/host/test_host_reverse.yml
@@ -57,7 +57,7 @@
update_dns: yes
reverse: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" present, again.
ipahost:
@@ -67,7 +67,7 @@
update_dns: yes
reverse: yes
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Hosts host1 absent
ipahost:
@@ -77,7 +77,7 @@
update_dns: yes
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" present with IPv6
ipahost:
@@ -87,7 +87,7 @@
update_dns: yes
reverse: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host "{{ host1_fqdn }}" present with IPv6, again.
ipahost:
@@ -97,7 +97,7 @@
update_dns: yes
reverse: yes
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Hosts host1 absent
ipahost:
@@ -107,7 +107,7 @@
update_dns: yes
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Delete zone for reverse address.
ipadnszone:
--
GitLab