From 4392e32f6ec55a4eeb487197ff447408423596be Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Fri, 3 Sep 2021 18:54:34 +0200
Subject: [PATCH] location: Use execute_ipa_commands
execute_ipa_commands replces the check mode exit, the loop over the
generated commands and also in the member failure handling for modules
with member support.
---
plugins/modules/ipalocation.py | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/plugins/modules/ipalocation.py b/plugins/modules/ipalocation.py
index 48d5b487..7f10b944 100644
--- a/plugins/modules/ipalocation.py
+++ b/plugins/modules/ipalocation.py
@@ -168,23 +168,8 @@ def main():
else:
ansible_module.fail_json(msg="Unkown state '%s'" % state)
- # Check mode exit
- if ansible_module.check_mode:
- ansible_module.exit_json(changed=len(commands) > 0, **exit_args)
-
# Execute commands
-
- for name, command, args in commands:
- try:
- result = ansible_module.ipa_command(command, name, args)
- if "completed" in result:
- if result["completed"] > 0:
- changed = True
- else:
- changed = True
- except Exception as e:
- ansible_module.fail_json(msg="%s: %s: %s" % (command, name,
- str(e)))
+ changed = ansible_module.execute_ipa_commands(commands)
# Done
--
GitLab