diff --git a/plugins/module_utils/ansible_freeipa_module.py b/plugins/module_utils/ansible_freeipa_module.py index a1f1402009c4076f15f7e69729cbcf01a39d6e09..3dffd44a99a8ec7e586097112850933ba46d2e1d 100644 --- a/plugins/module_utils/ansible_freeipa_module.py +++ b/plugins/module_utils/ansible_freeipa_module.py @@ -315,7 +315,7 @@ else: filtered_args = [key for key in args if key not in ignore] for key in filtered_args: - if key not in ipa: + if key not in ipa: # pylint: disable=no-else-return module.debug( base_debug_msg + "Command key not present in IPA: %s" % key ) @@ -367,15 +367,13 @@ else: if value is not None: if isinstance(value, list): return [_afm_convert(x) for x in value] - elif isinstance(value, dict): + if isinstance(value, dict): return {_afm_convert(k): _afm_convert(v) for k, v in value.items()} - elif isinstance(value, str): + if isinstance(value, str): return to_text(value) - else: - return value - else: - return value + + return value def module_params_get(module, name): return _afm_convert(module.params.get(name)) @@ -465,11 +463,10 @@ else: def DN_x500_text(text): # pylint: disable=invalid-name if hasattr(DN, "x500_text"): return DN(text).x500_text() - else: - # Emulate x500_text - dn = DN(text) - dn.rdns = reversed(dn.rdns) - return str(dn) + # Emulate x500_text + dn = DN(text) + dn.rdns = reversed(dn.rdns) + return str(dn) def is_valid_port(port): if not isinstance(port, int): diff --git a/plugins/modules/ipadnsconfig.py b/plugins/modules/ipadnsconfig.py index a0f2bc56c0454664b165296cd23e19cba3ba67c9..8d705807bc0d8ca057c7cede0153ee40e4da1bc7 100644 --- a/plugins/modules/ipadnsconfig.py +++ b/plugins/modules/ipadnsconfig.py @@ -114,8 +114,8 @@ def find_dnsconfig(module): if _result["result"].get('idnsforwarders', None) is None: _result["result"]['idnsforwarders'] = [''] return _result["result"] - else: - module.fail_json(msg="Could not retrieve current DNS configuration.") + + module.fail_json(msg="Could not retrieve current DNS configuration.") return None diff --git a/plugins/modules/ipadnszone.py b/plugins/modules/ipadnszone.py index b9601c6ababf846535846ee988b35d20ac901e5f..4ed9a9d2cc85f1c5fbf07d7dec2f18899b832028 100644 --- a/plugins/modules/ipadnszone.py +++ b/plugins/modules/ipadnszone.py @@ -404,10 +404,9 @@ class DNSZoneModule(FreeIPABaseModule): ip_version = ip.version if ip_version == 4: return u'.'.join(items[4 - prefixlen // 8:]) - elif ip_version == 6: + if ip_version == 6: return u'.'.join(items[32 - prefixlen // 4:]) - else: - self.fail_json(msg="Invalid IP version for reverse zone.") + self.fail_json(msg="Invalid IP version for reverse zone.") def get_zone(self, zone_name): get_zone_args = {"idnsname": zone_name, "all": True} diff --git a/plugins/modules/ipahbacsvcgroup.py b/plugins/modules/ipahbacsvcgroup.py index 560ebc5626267f03a78b262182977db4a6180b36..141fa5391448d93dede6dd74a5a5e817447574f9 100644 --- a/plugins/modules/ipahbacsvcgroup.py +++ b/plugins/modules/ipahbacsvcgroup.py @@ -121,7 +121,7 @@ def find_hbacsvcgroup(module, name): msg="There is more than one hbacsvcgroup '%s'" % (name)) elif len(_result["result"]) == 1: return _result["result"][0] - + return None diff --git a/plugins/modules/ipaservice.py b/plugins/modules/ipaservice.py index 77b934c123ad005f869d25d66ea993d61bb25889..cd55c76b054ce6dfb5d2be83b76d4d29337be211 100644 --- a/plugins/modules/ipaservice.py +++ b/plugins/modules/ipaservice.py @@ -250,8 +250,8 @@ def find_service(module, name): _res["usercertificate"] = [encode_certificate(cert) for cert in certs] return _res - else: - return None + + return None def gen_args(pac_type, auth_ind, skip_host_check, force, requires_pre_auth,