From 43d1a06b86c0dc9c28bb96feb2cfe7f48db9fb12 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman <rjeffman@redhat.com> Date: Thu, 30 Sep 2021 21:15:41 -0300 Subject: [PATCH] hbacsvc: Use IPAAnsibleModule method to validate arguments. Use the IPAAnsibleModule.params_fail_if_used method to validate arguments provided by user. --- plugins/modules/ipahbacsvc.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/modules/ipahbacsvc.py b/plugins/modules/ipahbacsvc.py index 12c8476d..30e9fdde 100644 --- a/plugins/modules/ipahbacsvc.py +++ b/plugins/modules/ipahbacsvc.py @@ -127,6 +127,7 @@ def main(): # Check parameters + invalid = [] if state == "present": if len(names) != 1: ansible_module.fail_json( @@ -137,11 +138,8 @@ def main(): ansible_module.fail_json( msg="No name given.") invalid = ["description"] - for x in invalid: - if vars()[x] is not None: - ansible_module.fail_json( - msg="Argument '%s' can not be used with state '%s'" % - (x, state)) + + ansible_module.params_fail_used_invalid(invalid, state) # Init -- GitLab