From 445705fb2cd5c98ff93de18c81177792bc9fdad1 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 21:50:26 +0200
Subject: [PATCH] dnszone: Fix no modifications to be performed for serial
A dnszone_mod call is always made to set the serial for a zone even if
this serial is set already.
A check is added to make sure that the serial is only set with
dnszone_mod if there is no serial set or if the serial is different.
---
plugins/modules/ipadnszone.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/plugins/modules/ipadnszone.py b/plugins/modules/ipadnszone.py
index 15cbec1d..038cdd2b 100644
--- a/plugins/modules/ipadnszone.py
+++ b/plugins/modules/ipadnszone.py
@@ -492,7 +492,13 @@ class DNSZoneModule(FreeIPABaseModule):
# See:
# - https://pagure.io/freeipa/issue/8227
# - https://pagure.io/freeipa/issue/8489
- if set_serial:
+ # Only set SOA Serial if it is not set already.
+ if (set_serial and
+ (zone is None
+ or "idnssoaserial" not in zone
+ or zone["idnssoaserial"] is None
+ or zone["idnssoaserial"][0] != str(self.ipa_params.serial)
+ )):
args = {
"idnssoaserial": self.ipa_params.serial,
}
--
GitLab