From 4aa78c68259aa2746feb3aa1432eb7119fd546f3 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:46 +0200
Subject: [PATCH] test_user_random.yml: Use result.failed also for failed_when

For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
 tests/user/test_user_random.yml | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/user/test_user_random.yml b/tests/user/test_user_random.yml
index 44b9373a..ce56abb0 100644
--- a/tests/user/test_user_random.yml
+++ b/tests/user/test_user_random.yml
@@ -22,7 +22,8 @@
       update_password: on_create
     register: ipauser
     failed_when: not ipauser.changed or
-                 ipauser.user.randompassword is not defined
+                 ipauser.user.randompassword is not defined or
+                 ipauser.failed
 
   - name: Print generated random password
     debug:
@@ -35,7 +36,7 @@
       - user1
       state: absent
 
-  - name: Users user1 and user1 present with random password
+  - name: Users user1 and user2 present with random password
     ipauser:
       ipaadmin_password: SomeADMINpassword
       users:
@@ -51,7 +52,8 @@
     register: ipauser
     failed_when: not ipauser.changed or
                  ipauser.user.user1.randompassword is not defined or
-                 ipauser.user.user2.randompassword is not defined
+                 ipauser.user.user2.randompassword is not defined or
+                 ipauser.failed
 
   - name: Print generated random password for user1
     debug:
-- 
GitLab