From 5c66c5bd95b0d3f8f548718418cad4e6cfdb4def Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:25 +0200
Subject: [PATCH] test_host_principal.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/host/test_host_principal.yml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/host/test_host_principal.yml b/tests/host/test_host_principal.yml
index 0e85626f..6c3e7c90 100644
--- a/tests/host/test_host_principal.yml
+++ b/tests/host/test_host_principal.yml
@@ -34,7 +34,7 @@
- "{{ 'host/testhost1.' + ipaserver_domain + '@' + ipaserver_realm }}"
force: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host host1... principal host/host1... present (existing already)
ipahost:
@@ -44,7 +44,7 @@
- "{{ 'host/host1.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host host1... principal host/testhost1... present again
ipahost:
@@ -53,7 +53,7 @@
principal: "{{ 'host/testhost1.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host host1... principal host/testhost1... absent
ipahost:
@@ -63,7 +63,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host host1... principal host/testhost1... absent again
ipahost:
@@ -73,7 +73,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host host1... principal host/testhost1... and host/myhost1... present
ipahost:
@@ -84,7 +84,7 @@
- "{{ 'host/myhost1.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host host1... principal host/testhost1... and host/myhost1... present again
ipahost:
@@ -95,7 +95,7 @@
- "{{ 'host/myhost1.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host host1... principal host/testhost1... and host/myhost1... absent
ipahost:
@@ -107,7 +107,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host host1... principal host/testhost1... and host/myhost1... absent again
ipahost:
@@ -119,7 +119,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host host1... absent
ipahost:
--
GitLab