diff --git a/plugins/module_utils/ansible_freeipa_module.py b/plugins/module_utils/ansible_freeipa_module.py index 8675beee9a8d3bf7bfbb7ab3aceef5c2fb4e5be4..f372301ff76f1a2b37fd3130fd5379c1d45db983 100644 --- a/plugins/module_utils/ansible_freeipa_module.py +++ b/plugins/module_utils/ansible_freeipa_module.py @@ -488,7 +488,7 @@ def module_params_get(module, name, allow_empty_list_item=False): if isinstance(value, list): for val in value: if ( - isinstance(val, (str, unicode)) # pylint: disable=E0606 + isinstance(val, (str, unicode)) # pylint: disable=W0012,E0606 and not val ): if not allow_empty_list_item: diff --git a/plugins/modules/ipagroup.py b/plugins/modules/ipagroup.py index 1ffdef9deb62e189a1b0955df6df4bcce88fae4a..6be6d5422b15d7cce67902903b6741d0e5f81a23 100644 --- a/plugins/modules/ipagroup.py +++ b/plugins/modules/ipagroup.py @@ -664,7 +664,9 @@ def main(): check_parameters(ansible_module, state, action) elif ( - isinstance(group_name, (str, unicode)) # pylint: disable=E0606 + isinstance( + group_name, (str, unicode) # pylint: disable=W0012,E0606 + ) ): name = group_name else: diff --git a/plugins/modules/ipahost.py b/plugins/modules/ipahost.py index 86336c46132a4d2da4b1f3c12a70e9eff2fec7d4..79d51f7fbd2b3340e732f00688da4dea5e7450e7 100644 --- a/plugins/modules/ipahost.py +++ b/plugins/modules/ipahost.py @@ -988,7 +988,9 @@ def main(): sshpubkey = [str(normalize_sshpubkey(key)) for key in sshpubkey] - elif isinstance(host, (str, unicode)): # pylint: disable=E0606 + elif ( + isinstance(host, (str, unicode)) # pylint: disable=W0012,E0606 + ): name = host else: ansible_module.fail_json(msg="Host '%s' is not valid" % diff --git a/plugins/modules/iparole.py b/plugins/modules/iparole.py index 25017e76696bdecd41fc1703e9132b7920d09cfc..ba77db9ac66a0d27b07285f1d788176e3b81ef2d 100644 --- a/plugins/modules/iparole.py +++ b/plugins/modules/iparole.py @@ -293,7 +293,7 @@ def result_get_value_lowercase(res_find, key, default=None): if existing is not None: if isinstance(existing, (list, tuple)): existing = [to_text(item).lower() for item in existing] - if isinstance(existing, (str, unicode)): # pylint: disable=E0606 + if isinstance(existing, (str, unicode)): # pylint: disable=W0012,E0606 existing = existing.lower() else: existing = default diff --git a/plugins/modules/ipaservice.py b/plugins/modules/ipaservice.py index 8326d4228a2e771a00ebf25f602d0f65d88ff239..5cf821210377382d4c3dce650dbb13d9e3b992aa 100644 --- a/plugins/modules/ipaservice.py +++ b/plugins/modules/ipaservice.py @@ -693,7 +693,11 @@ def main(): delete_continue = service.get("delete_continue") - elif isinstance(service, (str, unicode)): # pylint: disable=E0606 + elif ( + isinstance( + service, (str, unicode) # pylint: disable=W0012,E0606 + ) + ): name = service else: ansible_module.fail_json(msg="Service '%s' is not valid" % diff --git a/plugins/modules/ipauser.py b/plugins/modules/ipauser.py index d7c18082d7056d00f888b1f610fa1525e29e97a8..37fe734a2e8f7ff15cff99d916db2e9d393daa31 100644 --- a/plugins/modules/ipauser.py +++ b/plugins/modules/ipauser.py @@ -1382,7 +1382,11 @@ def main(): email = extend_emails(email, default_email_domain) - elif isinstance(user, (str, unicode)): # pylint: disable=E0606 + elif ( + isinstance( + user, (str, unicode) # pylint: disable=W0012,E0606 + ) + ): name = user else: ansible_module.fail_json(msg="User '%s' is not valid" % diff --git a/roles/ipareplica/library/ipareplica_add_to_ipaservers.py b/roles/ipareplica/library/ipareplica_add_to_ipaservers.py index 6fb8b1f92162e6fe07bf3e771e0d71cf6bae790f..4056f705dd8e0f9e234bebfe6402c7b8fd1cf25a 100644 --- a/roles/ipareplica/library/ipareplica_add_to_ipaservers.py +++ b/roles/ipareplica/library/ipareplica_add_to_ipaservers.py @@ -139,7 +139,7 @@ def main(): conn.connect(ccache=installer._ccache) remote_api.Command['hostgroup_add_member']( u'ipaservers', - host=[unicode(api.env.host)], # pylint: disable=E0606 + host=[unicode(api.env.host)], # pylint: disable=W0012,E0606 ) finally: if conn.isconnected(): diff --git a/roles/ipareplica/library/ipareplica_prepare.py b/roles/ipareplica/library/ipareplica_prepare.py index 5d9fd2d54614c3a97861a2dc638a21cf0efa04e2..63f1dcbdc97a74f1319d73dcfac045e351d82cff 100644 --- a/roles/ipareplica/library/ipareplica_prepare.py +++ b/roles/ipareplica/library/ipareplica_prepare.py @@ -658,7 +658,7 @@ def main(): # Check authorization result = remote_api.Command['hostgroup_find']( cn=u'ipaservers', - host=[unicode(api.env.host)] # pylint: disable=E0606 + host=[unicode(api.env.host)] # pylint: disable=W0012,E0606 )['result'] add_to_ipaservers = not result