From 869eb2fbdc76bc0f7e61a67aebfcab05ac8874e0 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:45 +0200
Subject: [PATCH] test_users_certmapdata.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
.../certmapdata/test_users_certmapdata.yml | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/user/certmapdata/test_users_certmapdata.yml b/tests/user/certmapdata/test_users_certmapdata.yml
index fdde23f4..b871fb9c 100644
--- a/tests/user/certmapdata/test_users_certmapdata.yml
+++ b/tests/user/certmapdata/test_users_certmapdata.yml
@@ -30,7 +30,7 @@
first: test
last: test
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test certmapdata members present
ipauser:
@@ -43,7 +43,7 @@
- certificate: "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test certmapdata members present again
ipauser:
@@ -56,7 +56,7 @@
- certificate: "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test certmapdata members absent
ipauser:
@@ -70,7 +70,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test certmapdata members absent again
ipauser:
@@ -84,7 +84,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test certmapdata members present
ipauser:
@@ -100,7 +100,7 @@
subject: CN=subject3
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test certmapdata members present again
ipauser:
@@ -116,7 +116,7 @@
subject: CN=subject3
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test certmapdata members absent
ipauser:
@@ -133,7 +133,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test certmapdata members absent again
ipauser:
@@ -150,7 +150,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test absent
ipauser:
@@ -159,7 +159,7 @@
- name: test
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Remove certificate files.
shell:
--
GitLab