From 87aae5b39675834e25c9739beb65fcae28aa93d8 Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Fri, 30 Sep 2022 18:18:37 +0200 Subject: [PATCH] ipatopologysuffix: Fix documentation sections and agument spec ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `type: str` needs to be set for string parameters - `author` needs to be given with the github user also: `Name (@user)` argument_spec - `type="str"` needs to added to all string parameters The `copyright` date is extended with `-2022`. --- plugins/modules/ipatopologysuffix.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/modules/ipatopologysuffix.py b/plugins/modules/ipatopologysuffix.py index a860aa9d..efd68ec5 100644 --- a/plugins/modules/ipatopologysuffix.py +++ b/plugins/modules/ipatopologysuffix.py @@ -3,7 +3,7 @@ # Authors: # Thomas Woerner <twoerner@redhat.com> # -# Copyright (C) 2019 Red Hat +# Copyright (C) 2019-2022 Red Hat # see file 'COPYING' for use and warranty information # # This program is free software; you can redistribute it and/or modify @@ -39,14 +39,16 @@ extends_documentation_fragment: options: suffix: description: Topology suffix + type: str required: true choices: ["domain", "ca"] state: description: State to ensure + type: str default: verified choices: ["verified"] author: - - Thomas Woerner + - Thomas Woerner (@t-woerner) """ EXAMPLES = """ @@ -65,7 +67,7 @@ from ansible.module_utils.ansible_freeipa_module import IPAAnsibleModule def main(): ansible_module = IPAAnsibleModule( argument_spec=dict( - suffix=dict(choices=["domain", "ca"], required=True), + suffix=dict(type="str", choices=["domain", "ca"], required=True), state=dict(type="str", default="verified", choices=["verified"]), ), -- GitLab