From 903e002e85463e7540990e8854c3caee95bbd8e8 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Fri, 28 Oct 2022 19:24:16 +0200
Subject: [PATCH] ipasmartcard_server_validate_ca_certs: Fix doc sections and
agument spec
ansible-test with ansible-2.14 is adding a lot of new tests to ensure
that the documentation section and the agument spec is complete. Needed
changes:
DOCUMENTATION section
- `type: list` needs to be set for list parameters
- `elements: str` needs to be given for list of string parameters
- `required` tags need to be fixed according to the `argument_spec`
- `author` needs to be given with the github user also: `Name (@user)`
argument_spec
- `elements="str"` needs to be added to all list of string parameters
---
.../library/ipasmartcard_server_validate_ca_certs.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/roles/ipasmartcard_server/library/ipasmartcard_server_validate_ca_certs.py b/roles/ipasmartcard_server/library/ipasmartcard_server_validate_ca_certs.py
index 7463efef..b776e584 100644
--- a/roles/ipasmartcard_server/library/ipasmartcard_server_validate_ca_certs.py
+++ b/roles/ipasmartcard_server/library/ipasmartcard_server_validate_ca_certs.py
@@ -41,9 +41,11 @@ options:
description:
List of files containing CA certificates for the service certificate
files
- required: yes
+ type: list
+ elements: str
+ required: no
author:
- - Thomas Woerner
+ - Thomas Woerner (@t-woerner)
'''
EXAMPLES = '''
@@ -63,7 +65,8 @@ except ImportError:
def main():
ansible_module = AnsibleModule(
argument_spec=dict(
- ca_cert_files=dict(required=False, type='list', default=[]),
+ ca_cert_files=dict(required=False, type='list', elements='str',
+ default=[]),
),
supports_check_mode=False,
)
--
GitLab