From 914e4879f8f39f6ec666f5eb86c5508ac27f53f6 Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Tue, 30 Nov 2021 19:18:17 -0300
Subject: [PATCH] tests/utils.py: Fix pylint issues.
---
tests/sanity/ignore-2.12.txt | 1 -
tests/utils.py | 9 ++++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/sanity/ignore-2.12.txt b/tests/sanity/ignore-2.12.txt
index b08a6ffa..ee85fb0a 100644
--- a/tests/sanity/ignore-2.12.txt
+++ b/tests/sanity/ignore-2.12.txt
@@ -43,7 +43,6 @@ tests/sanity/sanity.sh shebang!skip
tests/user/users.sh shebang!skip
tests/user/users_absent.sh shebang!skip
tests/utils.py pylint:ansible-format-automatic-specification
-tests/utils.py pylint:subprocess-run-check
utils/ansible-doc-test shebang!skip
utils/ansible-ipa-client-install shebang!skip
utils/ansible-ipa-replica-install shebang!skip
diff --git a/tests/utils.py b/tests/utils.py
index ae7cd48d..db22f973 100644
--- a/tests/utils.py
+++ b/tests/utils.py
@@ -174,6 +174,7 @@ def _run_playbook(playbook):
inventory_file.name,
playbook,
]
+ # pylint: disable=subprocess-run-check
process = subprocess.run(
cmd, cwd=SCRIPT_DIR, stdout=subprocess.PIPE, stderr=subprocess.PIPE
)
@@ -300,11 +301,13 @@ class AnsibleFreeIPATestCase(TestCase):
host_connection_info, ssh_identity_file=ssh_identity_file,
)
- def run_playbook(self, playbook, allow_failures=False):
+ @staticmethod
+ def run_playbook(playbook, allow_failures=False):
return run_playbook(playbook, allow_failures)
- def run_playbook_with_exp_msg(self, playbook, expected_msg):
- result = self.run_playbook(playbook, allow_failures=True)
+ @staticmethod
+ def run_playbook_with_exp_msg(playbook, expected_msg):
+ result = run_playbook(playbook, allow_failures=True)
assert (
expected_msg in result.stdout.decode("utf8")
or
--
GitLab