From 99289fc33e6b30351c70d9714a280b388f56c14d Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Tue, 8 Nov 2022 14:08:04 +0100 Subject: [PATCH] ipareplica_setup_certmonger: Fix documentation sections and agument spec ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `suboptions` needs to be removed without arguments - `author` needs to be given with the github user also: `Name (@user)` supports_check_mode is turned off as it is not supported. A call to ansible_ipa_replica.check_imports has been added to check for import errors. The `copyright` date is extended with `-2022`. --- roles/ipareplica/library/ipareplica_setup_certmonger.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/roles/ipareplica/library/ipareplica_setup_certmonger.py b/roles/ipareplica/library/ipareplica_setup_certmonger.py index 4029ed00..74af0fee 100644 --- a/roles/ipareplica/library/ipareplica_setup_certmonger.py +++ b/roles/ipareplica/library/ipareplica_setup_certmonger.py @@ -5,7 +5,7 @@ # # Based on ipa-replica-install code # -# Copyright (C) 2018 Red Hat +# Copyright (C) 2018-2022 Red Hat # see file 'COPYING' for use and warranty information # # This program is free software; you can redistribute it and/or modify @@ -37,9 +37,8 @@ module: ipareplica_setup_certmonger short_description: Setup certmonger description: Setup certmonger -options: author: - - Thomas Woerner + - Thomas Woerner (@t-woerner) ''' EXAMPLES = ''' @@ -50,6 +49,7 @@ RETURN = ''' from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.ansible_ipa_replica import ( + check_imports, AnsibleModuleLog, setup_logging, redirect_stdout, configure_certmonger ) @@ -57,10 +57,11 @@ from ansible.module_utils.ansible_ipa_replica import ( def main(): ansible_module = AnsibleModule( argument_spec={}, - supports_check_mode=True, + supports_check_mode=False, ) ansible_module._ansible_debug = True + check_imports(ansible_module) setup_logging() ansible_log = AnsibleModuleLog(ansible_module) -- GitLab