From a26e38c88000373f24737b1ddb51588c35bdac7e Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:39 +0200
Subject: [PATCH] test_sudocmd.yml: Use result.failed also for failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/sudocmd/test_sudocmd.yml | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/tests/sudocmd/test_sudocmd.yml b/tests/sudocmd/test_sudocmd.yml
index c66e8108..992dba7d 100644
--- a/tests/sudocmd/test_sudocmd.yml
+++ b/tests/sudocmd/test_sudocmd.yml
@@ -21,7 +21,7 @@
name: /usr/bin/su
state: present
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure sudocmd is present again
ipasudocmd:
@@ -29,7 +29,7 @@
name: /usr/bin/su
state: present
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure sudocmd is absent
ipasudocmd:
@@ -37,7 +37,7 @@
name: /usr/bin/su
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure sudocmd is absent again
ipasudocmd:
@@ -45,7 +45,7 @@
name: /usr/bin/su
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure multiple sudocmd are present
ipasudocmd:
@@ -55,7 +55,7 @@
- /usr/sbin/iwlist
state: present
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure multiple sudocmd are present again
ipasudocmd:
@@ -65,7 +65,7 @@
- /usr/sbin/iwlist
state: present
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure multiple sudocmd are absent
ipasudocmd:
@@ -75,7 +75,7 @@
- /usr/sbin/iwlist
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure multiple sudocmd are absent again
ipasudocmd:
@@ -85,7 +85,8 @@
- /usr/sbin/iwlist
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
+
- name: Ensure sudocmds are absent
ipasudocmd:
ipaadmin_password: SomeADMINpassword
@@ -117,4 +118,4 @@
- /usr/sbin/iwlist
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
--
GitLab