From aa57aa56f4c2b67131fa4d565860014b5531d0cd Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:18 +0200
Subject: [PATCH] test_hbacsvcgroup.yml: Use result.failed also for failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/hbacsvcgroup/test_hbacsvcgroup.yml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/hbacsvcgroup/test_hbacsvcgroup.yml b/tests/hbacsvcgroup/test_hbacsvcgroup.yml
index 853efa29..d0cd02cd 100644
--- a/tests/hbacsvcgroup/test_hbacsvcgroup.yml
+++ b/tests/hbacsvcgroup/test_hbacsvcgroup.yml
@@ -21,14 +21,14 @@
ipaadmin_password: SomeADMINpassword
name: login
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC Service Group login is present again
ipahbacsvcgroup:
ipaadmin_password: SomeADMINpassword
name: login
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC Service sshd is present in HBAC Service Group login
ipahbacsvcgroup:
@@ -38,7 +38,7 @@
- sshd
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC Service sshd is present in HBAC Service Group login again
ipahbacsvcgroup:
@@ -48,7 +48,7 @@
- sshd
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC Services sshd and foo are absent in HBAC Service Group login
ipahbacsvcgroup:
@@ -60,7 +60,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC Services sshd and foo are absent in HBAC Service Group login again
ipahbacsvcgroup:
@@ -72,7 +72,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Ensure HBAC Service Group login is absent
ipahbacsvcgroup:
@@ -80,7 +80,7 @@
name: login
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Ensure HBAC Service Group login is absent again
ipahbacsvcgroup:
@@ -88,4 +88,4 @@
name: login
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
--
GitLab