From ae2f452c60001d3e24ec2059a832a0def036adf7 Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Mon, 13 Sep 2021 14:13:58 -0300
Subject: [PATCH] sudocmd: Use execute_ipa_commands
execute_ipa_commands replces the check mode exit, the loop over the
generated commands and also in the member failure handling for modules
with member support.
---
plugins/modules/ipasudocmd.py | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/plugins/modules/ipasudocmd.py b/plugins/modules/ipasudocmd.py
index 1785e78e..20548ecf 100644
--- a/plugins/modules/ipasudocmd.py
+++ b/plugins/modules/ipasudocmd.py
@@ -167,22 +167,7 @@ def main():
else:
ansible_module.fail_json(msg="Unkown state '%s'" % state)
- # Check mode exit
- if ansible_module.check_mode:
- ansible_module.exit_json(changed=len(commands) > 0, **exit_args)
-
- # Execute commands
- for name, command, args in commands:
- try:
- result = ansible_module.ipa_command(command, name, args)
- # Check if any changes were made by any command
- if command == 'sudocmd_del':
- changed |= "Deleted" in result['summary']
- elif command == 'sudocmd_add':
- changed |= "Added" in result['summary']
- except Exception as e:
- ansible_module.fail_json(msg="%s: %s: %s" % (command, name,
- str(e)))
+ changed = ansible_module.execute_ipa_commands(commands)
# Done
--
GitLab