From b7b4f2291dabf379dc9f01579f256c68f1f70031 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:29 +0200
Subject: [PATCH] test_hosts_principal.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
---
tests/host/test_hosts_principal.yml | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/tests/host/test_hosts_principal.yml b/tests/host/test_hosts_principal.yml
index 67b4a202..4276da61 100644
--- a/tests/host/test_hosts_principal.yml
+++ b/tests/host/test_hosts_principal.yml
@@ -41,7 +41,7 @@
- "{{ 'host/testhost2.' + ipaserver_domain + '@' + ipaserver_realm }}"
force: yes
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host hostX... principal 'host/hostX... present (existing already) X=[1,2]
ipahost:
@@ -55,7 +55,7 @@
- "{{ 'host/host2.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host hostX... principal host/testhostX... present again X=[1,2]
ipahost:
@@ -69,7 +69,7 @@
- "{{ 'host/testhost2.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host hostX.. principal host/testhostX... absent X=[1,2]
ipahost:
@@ -84,7 +84,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host hostX... principal host/testhostX... absent again X=[1,2]
ipahost:
@@ -99,7 +99,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host hostX... principal host/testhostX... and host/myhostX... present X=[1,2]
ipahost:
@@ -115,7 +115,7 @@
- "{{ 'host/myhost2.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host hostX... principal host/testhostX... and host/myhostX... present again X=[1,2]
ipahost:
@@ -131,7 +131,7 @@
- "{{ 'host/myhost2.' + ipaserver_domain + '@' + ipaserver_realm }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Host hostX... principal host/testhostX... and host/myhostX... absent X=[1,2]
ipahost:
@@ -148,7 +148,7 @@
action: member
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Host hostX... principal host/testhostX... and host/myhostX... absent again X=[1,2]
ipahost:
@@ -165,7 +165,7 @@
action: member
state: absent
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: Hosts host1... and host2... absent
ipahost:
--
GitLab