From baa7cae8bf0f5fd56495b556535715e2699281a4 Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Tue, 3 Jan 2023 17:06:29 -0300
Subject: [PATCH] roles: Fix task names to start with uppercase letters
ansible-lint warns if task names don't start with an uppercase letter.
---
roles/ipaclient/tasks/install.yml | 2 +-
roles/ipasmartcard_client/tasks/main.yml | 6 +++---
roles/ipasmartcard_server/tasks/main.yml | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/roles/ipaclient/tasks/install.yml b/roles/ipaclient/tasks/install.yml
index 922259b9..174eefaf 100644
--- a/roles/ipaclient/tasks/install.yml
+++ b/roles/ipaclient/tasks/install.yml
@@ -273,7 +273,7 @@
ansible.builtin.fail:
msg: "The IPA test failed, please enable allow_repair to fix this."
when: not result_ipaclient_test_keytab.ping_test_ok
- - name: ca.crt file is missing
+ - name: Fail due to missing ca.crt file
ansible.builtin.fail:
msg: >
The ca.crt file is missing, please enable allow_repair to fix this.
diff --git a/roles/ipasmartcard_client/tasks/main.yml b/roles/ipasmartcard_client/tasks/main.yml
index bdbfc801..f7ddb827 100644
--- a/roles/ipasmartcard_client/tasks/main.yml
+++ b/roles/ipasmartcard_client/tasks/main.yml
@@ -70,13 +70,13 @@
ipaadmin_principal: admin
when: ipaadmin_principal is undefined
- - name: kinit using "{{ ipaadmin_principal }}" password
+ - name: Authenticate using kinit and "{{ ipaadmin_principal }}" password
ansible.builtin.command: kinit "{{ ipaadmin_principal }}"
args:
stdin: "{{ ipaadmin_password }}"
when: ipaadmin_password is defined
- - name: kinit using "{{ ipaadmin_principal }}" keytab
+ - name: Authenticate using kinit and "{{ ipaadmin_principal }}" keytab
ansible.builtin.command: kinit -kt "{{ ipaadmin_keytab }}" "{{ ipaadmin_principal }}"
when: ipaadmin_keytab is defined
@@ -173,5 +173,5 @@
### ALWAYS ###
always:
- - name: kdestroy
+ - name: Destroy Kerberos tickets
ansible.builtin.command: kdestroy -A
diff --git a/roles/ipasmartcard_server/tasks/main.yml b/roles/ipasmartcard_server/tasks/main.yml
index 1c214d05..a57ea6d1 100644
--- a/roles/ipasmartcard_server/tasks/main.yml
+++ b/roles/ipasmartcard_server/tasks/main.yml
@@ -55,13 +55,13 @@
ipaadmin_principal: admin
when: ipaadmin_principal is undefined
- - name: kinit using "{{ ipaadmin_principal }}" password
+ - name: Athenticate with kinit and "{{ ipaadmin_principal }}" password
ansible.builtin.command: kinit "{{ ipaadmin_principal }}"
args:
stdin: "{{ ipaadmin_password }}"
when: ipaadmin_password is defined
- - name: kinit using "{{ ipaadmin_principal }}" keytab
+ - name: Authenticate with kinit and "{{ ipaadmin_principal }}" keytab
ansible.builtin.command: kinit -kt "{{ ipaadmin_keytab }}" "{{ ipaadmin_principal }}"
when: ipaadmin_keytab is defined
@@ -250,5 +250,5 @@
### ALWAYS ###
always:
- - name: kdestroy
+ - name: Destroy Kereberos tickets
ansible.builtin.command: kdestroy -A
--
GitLab