From c542fb9f128ea9bcba3c5a8b0acac462f735bc6a Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Wed, 18 Nov 2020 17:04:07 -0300
Subject: [PATCH] ipasudocmdgroup: Remove unused sudocmdgroup.
Remove an unused attribute that has no parallel in IPA API.
---
plugins/modules/ipasudocmdgroup.py | 6 ------
tests/sudocmdgroup/test_sudocmdgroup.yml | 17 ++++++-----------
2 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/plugins/modules/ipasudocmdgroup.py b/plugins/modules/ipasudocmdgroup.py
index 9d9ce674..f1204fdb 100644
--- a/plugins/modules/ipasudocmdgroup.py
+++ b/plugins/modules/ipasudocmdgroup.py
@@ -50,10 +50,6 @@ options:
description: Suppress processing of membership attributes
required: false
type: bool
- sudocmdgroup:
- description: List of sudocmdgroup names assigned to this sudocmdgroup.
- required: false
- type: list
sudocmd:
description: List of sudocmds assigned to this sudocmdgroup.
required: false
@@ -157,7 +153,6 @@ def main():
# present
description=dict(type="str", default=None),
nomembers=dict(required=False, type='bool', default=None),
- sudocmdgroup=dict(required=False, type='list', default=None),
sudocmd=dict(required=False, type='list', default=None),
action=dict(type="str", default="sudocmdgroup",
choices=["member", "sudocmdgroup"]),
@@ -180,7 +175,6 @@ def main():
# present
description = ansible_module.params.get("description")
nomembers = ansible_module.params.get("nomembers")
- sudocmdgroup = ansible_module.params.get("sudocmdgroup")
sudocmd = ansible_module.params.get("sudocmd")
action = ansible_module.params.get("action")
# state
diff --git a/tests/sudocmdgroup/test_sudocmdgroup.yml b/tests/sudocmdgroup/test_sudocmdgroup.yml
index 0b039d3a..86b01f35 100644
--- a/tests/sudocmdgroup/test_sudocmdgroup.yml
+++ b/tests/sudocmdgroup/test_sudocmdgroup.yml
@@ -75,17 +75,12 @@
failed_when: result.changed
- name: Verify sudocmdgroup creation with sudocmds
- block:
- - name: Get Kerberos ticket for `admin`.
- shell: echo SomeADMINpassword | kinit -c test_sudocmdgroup_krb5ccname admin
-
- - name: Check sudocmdgroup-show output.
- shell: ipa sudocmdgroup-show network --all
- register: result
- failed_when: result.failed or not("/usr/sbin/ifconfig" in result.stdout and "/usr/sbin/iwlist" in result.stdout)
-
- - name: Destroy Kerberos tickets.
- shell: kdestroy -A -q -c test_sudocmdgroup_krb5ccname
+ shell: |
+ echo SomeADMINpassword | kinit -c verify_sudocmdgroup admin
+ KRB5CCNAME="verify_sudocmdgroup" ipa sudocmdgroup-show network --all
+ kdestroy -A -q -c verify_sudocmdgroup
+ register: result
+ failed_when: result.failed or not("/usr/sbin/ifconfig" in result.stdout and "/usr/sbin/iwlist" in result.stdout)
- name: Ensure sudocmdgroup, with sudocmds, is absent
ipasudocmdgroup:
--
GitLab