From cc942cb93247bd03d4b393e02bf8ec29e7a417e5 Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Wed, 3 Apr 2019 15:58:49 +0200 Subject: [PATCH] ipareplica_install_ca_certs: Cleanup of unused dns settings in options The dns settings in options have not been used and also not provided to the module in the tasks file. Therefore these settings shoul dbe removed. --- .../library/ipareplica_install_ca_certs.py | 41 ------------------- roles/ipareplica/tasks/install.yml | 2 - 2 files changed, 43 deletions(-) diff --git a/roles/ipareplica/library/ipareplica_install_ca_certs.py b/roles/ipareplica/library/ipareplica_install_ca_certs.py index ef1a4d3b..65eca21e 100644 --- a/roles/ipareplica/library/ipareplica_install_ca_certs.py +++ b/roles/ipareplica/library/ipareplica_install_ca_certs.py @@ -82,39 +82,6 @@ options: ca_subject: description: required: yes - reverse_zones: - description: - required: yes - no_reverse: - description: - required: yes - auto_reverse: - description: - required: yes - forwarders: - description: - required: yes - no_forwarders: - description: - required: yes -G auto_forwarders: - description: - required: yes - forward_policy: - description: - required: yes - enable_compat: - description: - required: yes - netbios_name: - description: - required: yes - rid_base: - description: - required: yes - secondary_rid_base: - description: - required: yes setup_ca: description: required: yes @@ -213,14 +180,6 @@ def main(): if options.subject_base is not None: options.subject_base = DN(options.subject_base) options.ca_subject = ansible_module.params.get('ca_subject') - ### dns ### - options.reverse_zones = ansible_module.params.get('reverse_zones') - options.no_reverse = ansible_module.params.get('no_reverse') - options.auto_reverse = ansible_module.params.get('auto_reverse') - options.forwarders = ansible_module.params.get('forwarders') - options.no_forwarders = ansible_module.params.get('no_forwarders') - options.auto_forwarders = ansible_module.params.get('auto_forwarders') - options.forward_policy = ansible_module.params.get('forward_policy') ### additional ### options.server = ansible_module.params.get('server') ccache = ansible_module.params.get('ccache') diff --git a/roles/ipareplica/tasks/install.yml b/roles/ipareplica/tasks/install.yml index 5928f21e..33ee62e0 100644 --- a/roles/ipareplica/tasks/install.yml +++ b/roles/ipareplica/tasks/install.yml @@ -204,8 +204,6 @@ dirsrv_cert_files: "{{ ipareplica_dirsrv_cert_files | default([]) }}" ### client ### force_join: "{{ ipaclient_force_join }}" - ### dns ### - forward_policy: "{{ ipareplica_forward_policy | default(omit) }}" ### ad trust ### netbios_name: "{{ ipareplica_netbios_name | default(omit) }}" rid_base: "{{ ipareplica_rid_base | default(omit) }}" -- GitLab