From d95029bbc00d69e0547f751b73c041c59fb20b80 Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Thu, 20 May 2021 13:16:20 +0200 Subject: [PATCH] test_hosts_certificate.yml: Use result.failed also for failed_when For failed_when result.failed should be used to make sure that the task fails if there was an error. --- tests/host/certificate/test_hosts_certificate.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/host/certificate/test_hosts_certificate.yml b/tests/host/certificate/test_hosts_certificate.yml index 00940f3c..a2b7eca0 100644 --- a/tests/host/certificate/test_hosts_certificate.yml +++ b/tests/host/certificate/test_hosts_certificate.yml @@ -23,7 +23,7 @@ - name: "{{ 'test.' + ipaserver_domain }}" force: yes register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Generate self-signed certificates. shell: @@ -46,7 +46,7 @@ - "{{ lookup('file', 'cert3.b64', rstrip=False) }}" action: member register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Host test cert members present again ipahost: @@ -59,7 +59,7 @@ - "{{ lookup('file', 'cert3.b64', rstrip=False) }}" action: member register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Host test cert members absent ipahost: @@ -73,7 +73,7 @@ state: absent action: member #register: result - #failed_when: not result.changed + #failed_when: not result.changed or result.failed - name: Host test cert members absent again ipahost: @@ -87,7 +87,7 @@ state: absent action: member register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Host test absent ipahost: @@ -96,7 +96,7 @@ - name: "{{ 'test.' + ipaserver_domain }}" state: absent register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Remove certificate files. shell: -- GitLab