From dd39368314bd019b3542b42dd5185701c658fd9a Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Thu, 20 May 2021 13:16:33 +0200 Subject: [PATCH] test_role_service_member.yml: Use result.failed also for failed_when For failed_when result.failed should be used to make sure that the task fails if there was an error. --- tests/role/test_role_service_member.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/role/test_role_service_member.yml b/tests/role/test_role_service_member.yml index 065cbce7..307dc94f 100644 --- a/tests/role/test_role_service_member.yml +++ b/tests/role/test_role_service_member.yml @@ -20,7 +20,7 @@ service: - "service01/{{ host1_fqdn }}" register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Ensure role with member service is present, again. iparole: @@ -30,7 +30,7 @@ - "service01/{{ host1_fqdn }}" action: member register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Ensure role has member service absent. iparole: @@ -41,7 +41,7 @@ action: member state: absent register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Ensure role has member service absent, again. iparole: @@ -52,7 +52,7 @@ action: member state: absent register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Ensure role has member service with principal name. iparole: @@ -62,7 +62,7 @@ - "service01/{{ host1_fqdn }}@{{ ipaserver_realm }}" action: member register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Ensure role has member service with principal name, again. iparole: @@ -72,7 +72,7 @@ - "service01/{{ host1_fqdn }}@{{ ipaserver_realm }}" action: member register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Ensure role is absent. iparole: @@ -80,7 +80,7 @@ name: testrole state: absent register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Ensure role is absent, again. iparole: @@ -88,7 +88,7 @@ name: testrole state: absent register: result - failed_when: result.changed + failed_when: result.changed or result.failed # cleanup - name: Cleanup environment. -- GitLab