From df87ff464ab19395815fd15605378c240c82262f Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman <rjeffman@redhat.com> Date: Wed, 30 Mar 2022 08:06:14 -0300 Subject: [PATCH] example playbooks: ipaadmin_password is used and consistent. Some example playbooks do not had the parameter `ipaadmin_password` set, and some had a different value than the standard value "SomeADMINpassword". This patch fixes this difference in all example playbooks. --- playbooks/automount/automountkey-renamed.yml | 2 +- playbooks/dnsconfig/disable-global-forwarders.yml | 1 + playbooks/dnsconfig/disallow-reverse-sync.yml | 1 + playbooks/dnsconfig/forwarders-absent.yml | 1 + playbooks/dnsconfig/forwarders-present.yml | 1 + playbooks/dnsconfig/set-configuration.yml | 1 + playbooks/dnsrecord/ensure-CNAME-record-is-absent.yml | 1 + playbooks/dnsrecord/ensure-CNAME-record-is-present.yml | 1 + playbooks/privilege/privilege-absent.yml | 1 + .../servicedelegationrule-absent.yml | 5 +++-- .../servicedelegationrule-present.yml | 3 ++- .../servicedelegationrule-principal-member-absent.yml | 9 +++++---- .../servicedelegationrule-principal-member-present.yml | 7 ++++--- .../servicedelegationrule-target-member-absent.yml | 9 +++++---- .../servicedelegationrule-target-member-present.yml | 7 ++++--- .../servicedelegationtarget-absent.yml | 5 +++-- .../servicedelegationtarget-member-absent.yml | 9 +++++---- .../servicedelegationtarget-member-present.yml | 7 ++++--- .../servicedelegationtarget-present.yml | 3 ++- playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml | 2 +- .../sudocmdgroup/ensure-sudocmdgroup-is-present.yml | 2 +- playbooks/sudorule/ensure-sudorule-is-absent.yml | 2 +- playbooks/topology/add-topologysegments.yml | 2 +- playbooks/topology/check-topologysegments.yml | 2 +- playbooks/topology/delete-topologysegments.yml | 2 +- playbooks/trust/add-trust.yml | 1 + playbooks/trust/del-trust.yml | 1 + 27 files changed, 54 insertions(+), 34 deletions(-) diff --git a/playbooks/automount/automountkey-renamed.yml b/playbooks/automount/automountkey-renamed.yml index ff60d117..68c68c58 100644 --- a/playbooks/automount/automountkey-renamed.yml +++ b/playbooks/automount/automountkey-renamed.yml @@ -5,7 +5,7 @@ tasks: - name: Ensure aumount key TestKey is renamed to NewKeyName ipaautomountkey: - ipaadmin_password: password01 + ipaadmin_password: SomeADMINpassword automountlocationcn: TestLocation automountmapname: TestMap automountkey: TestKey diff --git a/playbooks/dnsconfig/disable-global-forwarders.yml b/playbooks/dnsconfig/disable-global-forwarders.yml index 3b4f638c..2fc3ba43 100644 --- a/playbooks/dnsconfig/disable-global-forwarders.yml +++ b/playbooks/dnsconfig/disable-global-forwarders.yml @@ -6,4 +6,5 @@ tasks: - name: Disable global forwarders. ipadnsconfig: + ipaadmin_password: SomeADMINpassword forward_policy: none diff --git a/playbooks/dnsconfig/disallow-reverse-sync.yml b/playbooks/dnsconfig/disallow-reverse-sync.yml index e99996ef..129efabe 100644 --- a/playbooks/dnsconfig/disallow-reverse-sync.yml +++ b/playbooks/dnsconfig/disallow-reverse-sync.yml @@ -6,4 +6,5 @@ tasks: - name: Disallow reverse record synchronization. ipadnsconfig: + ipaadmin_password: SomeADMINpassword allow_sync_ptr: no diff --git a/playbooks/dnsconfig/forwarders-absent.yml b/playbooks/dnsconfig/forwarders-absent.yml index adcdb5d8..70d2e8a9 100644 --- a/playbooks/dnsconfig/forwarders-absent.yml +++ b/playbooks/dnsconfig/forwarders-absent.yml @@ -6,6 +6,7 @@ tasks: - name: Set dnsconfig forwarders. ipadnsconfig: + ipaadmin_password: SomeADMINpassword forwarders: - ip_address: 8.8.4.4 - ip_address: 2001:4860:4860::8888 diff --git a/playbooks/dnsconfig/forwarders-present.yml b/playbooks/dnsconfig/forwarders-present.yml index 4c0d25aa..12bca6e6 100644 --- a/playbooks/dnsconfig/forwarders-present.yml +++ b/playbooks/dnsconfig/forwarders-present.yml @@ -6,6 +6,7 @@ tasks: - name: Set dnsconfig forwarders. ipadnsconfig: + ipaadmin_password: SomeADMINpassword forwarders: - ip_address: 8.8.4.4 - ip_address: 2001:4860:4860::8888 diff --git a/playbooks/dnsconfig/set-configuration.yml b/playbooks/dnsconfig/set-configuration.yml index 17880aaf..ea56b6fc 100644 --- a/playbooks/dnsconfig/set-configuration.yml +++ b/playbooks/dnsconfig/set-configuration.yml @@ -6,6 +6,7 @@ tasks: - name: Set dnsconfig. ipadnsconfig: + ipaadmin_password: SomeADMINpassword forwarders: - ip_address: 8.8.4.4 - ip_address: 2001:4860:4860::8888 diff --git a/playbooks/dnsrecord/ensure-CNAME-record-is-absent.yml b/playbooks/dnsrecord/ensure-CNAME-record-is-absent.yml index 751fc043..4521133f 100644 --- a/playbooks/dnsrecord/ensure-CNAME-record-is-absent.yml +++ b/playbooks/dnsrecord/ensure-CNAME-record-is-absent.yml @@ -7,6 +7,7 @@ tasks: - name: Ensure that 'host04' has CNAME, with cname_hostname, is absent ipadnsrecord: + ipaadmin_password: SomeADMINpassword zone_name: example.com name: host04 cname_hostname: host04.example.com diff --git a/playbooks/dnsrecord/ensure-CNAME-record-is-present.yml b/playbooks/dnsrecord/ensure-CNAME-record-is-present.yml index 3a0c5b95..1e60b583 100644 --- a/playbooks/dnsrecord/ensure-CNAME-record-is-present.yml +++ b/playbooks/dnsrecord/ensure-CNAME-record-is-present.yml @@ -7,6 +7,7 @@ tasks: - name: Ensure that 'host04' has CNAME, with cname_hostname, is present ipadnsrecord: + ipaadmin_password: SomeADMINpassword zone_name: example.com name: host04 cname_hostname: host04.example.com diff --git a/playbooks/privilege/privilege-absent.yml b/playbooks/privilege/privilege-absent.yml index 6a72536e..b8d733e4 100644 --- a/playbooks/privilege/privilege-absent.yml +++ b/playbooks/privilege/privilege-absent.yml @@ -6,5 +6,6 @@ tasks: - name: Ensure privilege "Broad Privilege" is absent ipaprivilege: + ipaadmin_password: SomeADMINpassword name: Broad Privilege state: absent diff --git a/playbooks/servicedelegationrule/servicedelegationrule-absent.yml b/playbooks/servicedelegationrule/servicedelegationrule-absent.yml index 59956157..fb43f29f 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-absent.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-absent.yml @@ -6,5 +6,6 @@ tasks: - name: Ensure servicedelegationrule test-delegation-rule is absent ipaservicedelegationrule: - name: test-delegation-rule - state: absent + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule + state: absent diff --git a/playbooks/servicedelegationrule/servicedelegationrule-present.yml b/playbooks/servicedelegationrule/servicedelegationrule-present.yml index 8e3ccd49..bb1df132 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-present.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-present.yml @@ -6,4 +6,5 @@ tasks: - name: Ensure servicedelegationrule test-delegation-rule is present ipaservicedelegationrule: - name: test-delegation-rule + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule diff --git a/playbooks/servicedelegationrule/servicedelegationrule-principal-member-absent.yml b/playbooks/servicedelegationrule/servicedelegationrule-principal-member-absent.yml index 784da69a..9fbb7fd9 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-principal-member-absent.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-principal-member-absent.yml @@ -6,7 +6,8 @@ tasks: - name: Ensure principal member test/example.com is absent in servicedelegationrule test-delegation-rule ipaservicedelegationrule: - name: test-delegation-rule - principal: test/example.com - action: member - state: absent + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule + principal: test/example.com + action: member + state: absent diff --git a/playbooks/servicedelegationrule/servicedelegationrule-principal-member-present.yml b/playbooks/servicedelegationrule/servicedelegationrule-principal-member-present.yml index d8f96058..3fd034e3 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-principal-member-present.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-principal-member-present.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure principal member test/example.com is present in servicedelegationrule test-delegation-rule ipaservicedelegationrule: - name: test-delegation-rule - principal: test/example.com - action: member + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule + principal: test/example.com + action: member diff --git a/playbooks/servicedelegationrule/servicedelegationrule-target-member-absent.yml b/playbooks/servicedelegationrule/servicedelegationrule-target-member-absent.yml index cb280e4f..20321788 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-target-member-absent.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-target-member-absent.yml @@ -6,7 +6,8 @@ tasks: - name: Ensure member test/example.com is absent in servicedelegationrule test-delegation-rule ipaservicedelegationrule: - name: test-delegation-rule - principal: test/example.com - action: member - state: absent + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule + principal: test/example.com + action: member + state: absent diff --git a/playbooks/servicedelegationrule/servicedelegationrule-target-member-present.yml b/playbooks/servicedelegationrule/servicedelegationrule-target-member-present.yml index 257971d1..19a6cfe5 100644 --- a/playbooks/servicedelegationrule/servicedelegationrule-target-member-present.yml +++ b/playbooks/servicedelegationrule/servicedelegationrule-target-member-present.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure member test/example.com is present in servicedelegationrule test-delegation-rule ipaservicedelegationrule: - name: test-delegation-rule - principal: test/example.com - action: member + ipaadmin_password: SomeADMINpassword + name: test-delegation-rule + principal: test/example.com + action: member diff --git a/playbooks/servicedelegationtarget/servicedelegationtarget-absent.yml b/playbooks/servicedelegationtarget/servicedelegationtarget-absent.yml index 2314daa2..c93093d1 100644 --- a/playbooks/servicedelegationtarget/servicedelegationtarget-absent.yml +++ b/playbooks/servicedelegationtarget/servicedelegationtarget-absent.yml @@ -6,5 +6,6 @@ tasks: - name: Ensure servicedelegationtarget test-delegation-target is absent ipaservicedelegationtarget: - name: test-delegation-target - state: absent + ipaadmin_password: SomeADMINpassword + name: test-delegation-target + state: absent diff --git a/playbooks/servicedelegationtarget/servicedelegationtarget-member-absent.yml b/playbooks/servicedelegationtarget/servicedelegationtarget-member-absent.yml index 60036fef..2177f9df 100644 --- a/playbooks/servicedelegationtarget/servicedelegationtarget-member-absent.yml +++ b/playbooks/servicedelegationtarget/servicedelegationtarget-member-absent.yml @@ -6,7 +6,8 @@ tasks: - name: Ensure member test/example.com is absent in servicedelegationtarget test-delegation-target ipaservicedelegationtarget: - name: test-delegation-target - principal: test/example.com - action: member - state: absent + ipaadmin_password: SomeADMINpassword + name: test-delegation-target + principal: test/example.com + action: member + state: absent diff --git a/playbooks/servicedelegationtarget/servicedelegationtarget-member-present.yml b/playbooks/servicedelegationtarget/servicedelegationtarget-member-present.yml index 3907d573..0e5779ad 100644 --- a/playbooks/servicedelegationtarget/servicedelegationtarget-member-present.yml +++ b/playbooks/servicedelegationtarget/servicedelegationtarget-member-present.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure member test/example.com is present in servicedelegationtarget test-delegation-target ipaservicedelegationtarget: - name: test-delegation-target - principal: test/example.com - action: member + ipaadmin_password: SomeADMINpassword + name: test-delegation-target + principal: test/example.com + action: member diff --git a/playbooks/servicedelegationtarget/servicedelegationtarget-present.yml b/playbooks/servicedelegationtarget/servicedelegationtarget-present.yml index 868d411e..369da3a5 100644 --- a/playbooks/servicedelegationtarget/servicedelegationtarget-present.yml +++ b/playbooks/servicedelegationtarget/servicedelegationtarget-present.yml @@ -6,4 +6,5 @@ tasks: - name: Ensure servicedelegationtarget test-delegation-target is present ipaservicedelegationtarget: - name: test-delegation-target + ipaadmin_password: SomeADMINpassword + name: test-delegation-target diff --git a/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml b/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml index 338dad71..1850ed70 100644 --- a/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml +++ b/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-absent.yml @@ -6,7 +6,7 @@ tasks: - name: Ensure sudocmdgroup is absent ipasudocmdgroup: - ipaadmin_password: pass1234 + ipaadmin_password: SomeADMINpassword name: network state: absent action: sudocmdgroup diff --git a/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-present.yml b/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-present.yml index e97162cd..cdd12598 100644 --- a/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-present.yml +++ b/playbooks/sudocmdgroup/ensure-sudocmdgroup-is-present.yml @@ -6,7 +6,7 @@ tasks: - name: Ensure sudocmdgroup sudocmds are present ipasudocmdgroup: - ipaadmin_password: pass1234 + ipaadmin_password: SomeADMINpassword name: network description: Group of important commands. sudocmd: diff --git a/playbooks/sudorule/ensure-sudorule-is-absent.yml b/playbooks/sudorule/ensure-sudorule-is-absent.yml index 774ab75e..cf9b3fd6 100644 --- a/playbooks/sudorule/ensure-sudorule-is-absent.yml +++ b/playbooks/sudorule/ensure-sudorule-is-absent.yml @@ -6,6 +6,6 @@ tasks: - name: Ensure sudorule command is absent ipasudorule: - ipaadmin_password: pass1234 + ipaadmin_password: SomeADMINpassword name: testrule1 state: absent diff --git a/playbooks/topology/add-topologysegments.yml b/playbooks/topology/add-topologysegments.yml index c285a9f6..3f2a0efe 100644 --- a/playbooks/topology/add-topologysegments.yml +++ b/playbooks/topology/add-topologysegments.yml @@ -14,7 +14,7 @@ tasks: - name: Add topology segment ipatopologysegment: - ipaadmin_password: "{{ ipaadmin_password }}" + ipaadmin_password: SomeADMINpassword suffix: "{{ item.suffix }}" name: "{{ item.name | default(omit) }}" left: "{{ item.left }}" diff --git a/playbooks/topology/check-topologysegments.yml b/playbooks/topology/check-topologysegments.yml index 5770c178..1fbfc916 100644 --- a/playbooks/topology/check-topologysegments.yml +++ b/playbooks/topology/check-topologysegments.yml @@ -14,7 +14,7 @@ tasks: - name: Add topology segment ipatopologysegment: - ipaadmin_password: "{{ ipaadmin_password }}" + ipaadmin_password: SomeADMINpassword suffix: "{{ item.suffix }}" name: "{{ item.name | default(omit) }}" left: "{{ item.left }}" diff --git a/playbooks/topology/delete-topologysegments.yml b/playbooks/topology/delete-topologysegments.yml index 68b95b87..d26bc558 100644 --- a/playbooks/topology/delete-topologysegments.yml +++ b/playbooks/topology/delete-topologysegments.yml @@ -14,7 +14,7 @@ tasks: - name: Add topology segment ipatopologysegment: - ipaadmin_password: "{{ ipaadmin_password }}" + ipaadmin_password: SomeADMINpassword suffix: "{{ item.suffix }}" name: "{{ item.name | default(omit) }}" left: "{{ item.left }}" diff --git a/playbooks/trust/add-trust.yml b/playbooks/trust/add-trust.yml index 4ceedf5d..9842939a 100644 --- a/playbooks/trust/add-trust.yml +++ b/playbooks/trust/add-trust.yml @@ -6,6 +6,7 @@ tasks: - name: ensure the trust is present ipatrust: + ipaadmin_password: SomeADMINpassword realm: windows.local admin: Administrator password: secret_password diff --git a/playbooks/trust/del-trust.yml b/playbooks/trust/del-trust.yml index 9a8514d0..0d0f95f1 100644 --- a/playbooks/trust/del-trust.yml +++ b/playbooks/trust/del-trust.yml @@ -6,5 +6,6 @@ tasks: - name: ensure the trust is absent ipatrust: + ipaadmin_password: SomeADMINpassword realm: windows.local state: absent -- GitLab