From e0defaaebe869218abf73da521a0be5612b0e4f4 Mon Sep 17 00:00:00 2001
From: Thomas Woerner <twoerner@redhat.com>
Date: Thu, 20 May 2021 13:16:42 +0200
Subject: [PATCH] test_user_certificate.yml: Use result.failed also for
failed_when
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
Fixed also "User test cert members present again" task, it was failing
due to also having first and last parameters with action: member.
---
tests/user/certificate/test_user_certificate.yml | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/tests/user/certificate/test_user_certificate.yml b/tests/user/certificate/test_user_certificate.yml
index d1e157fd..5ea6fe90 100644
--- a/tests/user/certificate/test_user_certificate.yml
+++ b/tests/user/certificate/test_user_certificate.yml
@@ -32,21 +32,19 @@
- "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test cert members present again
ipauser:
ipaadmin_password: SomeADMINpassword
name: test
- first: test
- last: test
certificate:
- "{{ lookup('file', 'cert1.b64', rstrip=False) }}"
- "{{ lookup('file', 'cert2.b64', rstrip=False) }}"
- "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test cert members absent
ipauser:
@@ -59,7 +57,7 @@
state: absent
action: member
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: User test cert members absent again
ipauser:
@@ -72,7 +70,7 @@
state: absent
action: member
register: result
- failed_when: result.changed
+ failed_when: result.changed or result.failed
- name: User test absent
ipauser:
@@ -80,7 +78,7 @@
name: test
state: absent
register: result
- failed_when: not result.changed
+ failed_when: not result.changed or result.failed
- name: Remove certificate files.
shell:
--
GitLab