From e7b9e97a84dd446380059b145138967c2ffcaf6e Mon Sep 17 00:00:00 2001
From: Rafael Guterres Jeffman <rjeffman@redhat.com>
Date: Thu, 29 Apr 2021 18:54:33 -0300
Subject: [PATCH] Fix pylint warnings for name redefinition.
---
plugins/module_utils/ansible_freeipa_module.py | 4 ++--
plugins/modules/ipaconfig.py | 6 +++---
plugins/modules/ipadnsforwardzone.py | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/plugins/module_utils/ansible_freeipa_module.py b/plugins/module_utils/ansible_freeipa_module.py
index 3dffd44a..cd0a5b08 100644
--- a/plugins/module_utils/ansible_freeipa_module.py
+++ b/plugins/module_utils/ansible_freeipa_module.py
@@ -271,9 +271,9 @@ else:
'%Y-%m-%d %H:%MZ', # non-ISO 8601, minute precision
]
- for date_format in accepted_date_formats:
+ for _date_format in accepted_date_formats:
try:
- return datetime.strptime(value, date_format)
+ return datetime.strptime(value, _date_format)
except ValueError:
pass
raise ValueError("Invalid date '%s'" % value)
diff --git a/plugins/modules/ipaconfig.py b/plugins/modules/ipaconfig.py
index 5e4a1bae..b557baf5 100644
--- a/plugins/modules/ipaconfig.py
+++ b/plugins/modules/ipaconfig.py
@@ -399,11 +399,11 @@ def main():
("ipasearchrecordslimit", -1, 2147483647),
("ipapwdexpadvnotify", 0, 2147483647),
]
- for arg, min, max in args_with_limits:
- if arg in params and (params[arg] > max or params[arg] < min):
+ for arg, minimum, maximum in args_with_limits:
+ if arg in params and (params[arg] > maximum or params[arg] < minimum):
ansible_module.fail_json(
msg="Argument '%s' must be between %d and %d."
- % (arg, min, max))
+ % (arg, minimum, maximum))
changed = False
exit_args = {}
diff --git a/plugins/modules/ipadnsforwardzone.py b/plugins/modules/ipadnsforwardzone.py
index 5df7a1e8..1c2a22e5 100644
--- a/plugins/modules/ipadnsforwardzone.py
+++ b/plugins/modules/ipadnsforwardzone.py
@@ -386,8 +386,8 @@ def main():
**exit_args)
# Execute commands
- for name, command, args in commands:
- api_command(ansible_module, command, name, args)
+ for _name, command, args in commands:
+ api_command(ansible_module, command, _name, args)
changed = True
except Exception as e:
--
GitLab