From fba1cc1440fa41de77da986fdc85d135af46b5cd Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Fri, 3 Sep 2021 18:57:44 +0200 Subject: [PATCH] selfservice: Use execute_ipa_commands execute_ipa_commands replces the check mode exit, the loop over the generated commands and also in the member failure handling for modules with member support. --- plugins/modules/ipaselfservice.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/plugins/modules/ipaselfservice.py b/plugins/modules/ipaselfservice.py index 81b4461c..53bd5b3b 100644 --- a/plugins/modules/ipaselfservice.py +++ b/plugins/modules/ipaselfservice.py @@ -278,17 +278,7 @@ def main(): # Execute commands - for name, command, args in commands: - try: - result = ansible_module.ipa_command(command, name, args) - if "completed" in result: - if result["completed"] > 0: - changed = True - else: - changed = True - except Exception as e: - ansible_module.fail_json(msg="%s: %s: %s" % (command, name, - str(e))) + changed = ansible_module.execute_ipa_commands(commands) # Done -- GitLab