From fc3f64f0f11db9b6cb111df02552493eb8b1bd2d Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman <rjeffman@redhat.com> Date: Thu, 30 Sep 2021 21:16:50 -0300 Subject: [PATCH] location: Use IPAAnsibleModule method to validate arguments. Use the IPAAnsibleModule.params_fail_if_used method to validate arguments provided by user. --- plugins/modules/ipalocation.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/plugins/modules/ipalocation.py b/plugins/modules/ipalocation.py index 7f10b944..9b017cd0 100644 --- a/plugins/modules/ipalocation.py +++ b/plugins/modules/ipalocation.py @@ -116,7 +116,7 @@ def main(): state = ansible_module.params_get("state") # Check parameters - + invalid = [] if state == "present": if len(names) != 1: ansible_module.fail_json( @@ -126,11 +126,8 @@ def main(): if len(names) < 1: ansible_module.fail_json(msg="No name given.") invalid = ["description"] - for x in invalid: - if vars()[x] is not None: - ansible_module.fail_json( - msg="Argument '%s' can not be used with state '%s'" % - (x, state)) + + ansible_module.params_fail_used_invalid(invalid, state) # Init -- GitLab