From ff08ee7ee699155c34c894f3743afbd626c2d4ed Mon Sep 17 00:00:00 2001 From: Thomas Woerner <twoerner@redhat.com> Date: Tue, 30 Jul 2019 11:48:31 +0200 Subject: [PATCH] ipaserver_test,ipareplica_prepare: Do not return _pkcs12_file settings These settings are file descriptors if external certificates are used and are not used later in the roles. Therefore these settings have been removed. Fixes: #110 (Ansible error with external certificates) --- roles/ipareplica/library/ipareplica_prepare.py | 3 --- roles/ipaserver/library/ipaserver_test.py | 3 --- 2 files changed, 6 deletions(-) diff --git a/roles/ipareplica/library/ipareplica_prepare.py b/roles/ipareplica/library/ipareplica_prepare.py index a3f72237..3d9230ba 100644 --- a/roles/ipareplica/library/ipareplica_prepare.py +++ b/roles/ipareplica/library/ipareplica_prepare.py @@ -2043,13 +2043,10 @@ def main(): _ca_file=cafile, _top_dir=installer._top_dir, _add_to_ipaservers=add_to_ipaservers, - _dirsrv_pkcs12_file=dirsrv_pkcs12_file, _dirsrv_pkcs12_info=dirsrv_pkcs12_info, _dirsrv_ca_cert=dirsrv_ca_cert, - _http_pkcs12_file=http_pkcs12_file, _http_pkcs12_info=http_pkcs12_info, _http_ca_cert=http_ca_cert, - _pkinit_pkcs12_file=pkinit_pkcs12_file, _pkinit_pkcs12_info=pkinit_pkcs12_info, _pkinit_ca_cert=pkinit_ca_cert, no_dnssec_validation=options.no_dnssec_validation, diff --git a/roles/ipaserver/library/ipaserver_test.py b/roles/ipaserver/library/ipaserver_test.py index 71c40007..1075e6d4 100644 --- a/roles/ipaserver/library/ipaserver_test.py +++ b/roles/ipaserver/library/ipaserver_test.py @@ -1032,13 +1032,10 @@ def main(): idmax=options.idmax, no_pkinit=options.no_pkinit, # ssl certificate - _dirsrv_pkcs12_file=dirsrv_pkcs12_file, _dirsrv_pkcs12_info=dirsrv_pkcs12_info, _dirsrv_ca_cert=dirsrv_ca_cert, - _http_pkcs12_file=http_pkcs12_file, _http_pkcs12_info=http_pkcs12_info, _http_ca_cert=http_ca_cert, - _pkinit_pkcs12_file=pkinit_pkcs12_file, _pkinit_pkcs12_info=pkinit_pkcs12_info, _pkinit_ca_cert=pkinit_ca_cert, # certificate system -- GitLab