From 33a60fe919b50a149ef6402f56e342989f6eea23 Mon Sep 17 00:00:00 2001
From: Kenichi Omichi <ken1ohmichi@gmail.com>
Date: Wed, 9 Dec 2020 07:14:51 -0800
Subject: [PATCH] Fix warning of mkdir usage (#6951)

This fixes the following warning:

  [kubernetes/client : Generate admin kubeconfig with external api endpoint]
  [WARNING]: Consider using the file module with state=directory rather than
  running 'mkdir'.  If you need to use command because file is insufficient
  you can
---
 roles/kubernetes/client/tasks/main.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/roles/kubernetes/client/tasks/main.yml b/roles/kubernetes/client/tasks/main.yml
index 8c7fba34f..0fa2de233 100644
--- a/roles/kubernetes/client/tasks/main.yml
+++ b/roles/kubernetes/client/tasks/main.yml
@@ -47,10 +47,16 @@
     port: "{{ kube_apiserver_port }}"
     timeout: 180
 
+- name: Create external_kubeconfig dir
+  file:
+    path: "{{ kube_config_dir }}/external_kubeconfig"
+    mode: "0750"
+    state: directory
+  when: kubeconfig_localhost
+
 # NOTE(mattymo): Please forgive this workaround
 - name: Generate admin kubeconfig with external api endpoint  # noqa 302
   shell: >-
-    mkdir -p {{ kube_config_dir }}/external_kubeconfig &&
     {{ bin_dir }}/kubeadm
     init phase
     kubeconfig admin
-- 
GitLab