From 7e4f4a96fc62b449f041c792b50062ca1195d8a7 Mon Sep 17 00:00:00 2001
From: Victor Morales <chipahuac@hotmail.com>
Date: Mon, 8 Apr 2019 00:32:26 -0700
Subject: [PATCH] Replace iteritems() to items() in Jinja2 templates (#4437)

The iteritems() dictionary's method has been removed in Python3. Using
this method in Jinja2 templates limits the execution to Python2 which
will be deprecated in 2020[1]. This change replaces that method for
the items() method as it's suggested in the official website[2].

[1] https://pythonclock.org/
[2] https://docs.ansible.com/ansible/latest/user_guide/playbooks_python_version.html#dict-iteritems
---
 .../oci/templates/controller-manager-config.yml.j2            | 2 +-
 .../templates/local-volume-provisioner-cm.yml.j2              | 2 +-
 .../templates/local-volume-provisioner-ds.yml.j2              | 4 ++--
 .../templates/local-volume-provisioner-psp.yml.j2             | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/roles/kubernetes-apps/cloud_controller/oci/templates/controller-manager-config.yml.j2 b/roles/kubernetes-apps/cloud_controller/oci/templates/controller-manager-config.yml.j2
index 36b4b2df7..695cc55b4 100644
--- a/roles/kubernetes-apps/cloud_controller/oci/templates/controller-manager-config.yml.j2
+++ b/roles/kubernetes-apps/cloud_controller/oci/templates/controller-manager-config.yml.j2
@@ -66,7 +66,7 @@ loadBalancer:
 {% if oci_security_lists is defined and oci_security_lists|length > 0 %}
   # Optional specification of which security lists to modify per subnet. This does not apply if security list management is off.
   securityLists:
-{% for subnet_ocid, list_ocid in oci_security_lists.iteritems() %}
+{% for subnet_ocid, list_ocid in oci_security_lists.items() %}
     {{ subnet_ocid }}: {{ list_ocid }}
 {% endfor %}
 {% endif %}
diff --git a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-cm.yml.j2 b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-cm.yml.j2
index 7dc4f2fa4..4f67c0e6a 100644
--- a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-cm.yml.j2
+++ b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-cm.yml.j2
@@ -17,7 +17,7 @@ metadata:
   namespace: {{ local_volume_provisioner_namespace }}
 data:
   storageClassMap: |
-{% for class_name, storage_class in local_volume_provisioner_storage_classes.iteritems() %}
+{% for class_name, storage_class in local_volume_provisioner_storage_classes.items() %}
     {{ class_name }}:
       {{- convert_keys(storage_class) }}
       {{ storage_class | to_nice_yaml(indent=2) | indent(6) }}
diff --git a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-ds.yml.j2 b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-ds.yml.j2
index 28062aae3..b1c05c244 100644
--- a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-ds.yml.j2
+++ b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-ds.yml.j2
@@ -44,7 +44,7 @@ spec:
             - name: local-volume-provisioner
               mountPath: /etc/provisioner/config
               readOnly: true
-{% for class_name, class_config in local_volume_provisioner_storage_classes.iteritems() %}
+{% for class_name, class_config in local_volume_provisioner_storage_classes.items() %}
             - name: local-volume-provisioner-hostpath-{{ class_name }}
               mountPath: {{ class_config.mount_dir }}
               mountPropagation: "HostToContainer"
@@ -53,7 +53,7 @@ spec:
         - name: local-volume-provisioner
           configMap:
             name: local-volume-provisioner
-{% for class_name, class_config in local_volume_provisioner_storage_classes.iteritems() %}
+{% for class_name, class_config in local_volume_provisioner_storage_classes.items() %}
         - name: local-volume-provisioner-hostpath-{{ class_name }}
           hostPath:
             path: {{ class_config.host_dir }}
diff --git a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-psp.yml.j2 b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-psp.yml.j2
index a7442f123..12bdd0401 100644
--- a/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-psp.yml.j2
+++ b/roles/kubernetes-apps/external_provisioner/local_volume_provisioner/templates/local-volume-provisioner-psp.yml.j2
@@ -25,7 +25,7 @@ spec:
     - 'downwardAPI'
     - 'hostPath'
   allowedHostPaths:
-{% for class_name, class_config in local_volume_provisioner_storage_classes.iteritems() %}
+{% for class_name, class_config in local_volume_provisioner_storage_classes.items() %}
     - pathPrefix: "{{ class_config.host_dir }}"
       readOnly: false
 {% endfor %}
-- 
GitLab