Do not use ‘yes/no’ for boolean values (#11472)

Consistent boolean values in ansible playbooks

roles/bootstrap-os/tasks/redhat.yml

@@ -87,9 +87,9 @@
 - name: Check presence of fastestmirror.conf
   stat:
     path: /etc/yum/pluginconf.d/fastestmirror.conf
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: fastestmirror
 
 # the fastestmirror plugin can actually slow down Ansible deployments

roles/bootstrap-os/vars/fedora-coreos.yml

 ---
-is_fedora_coreos: True
+is_fedora_coreos: true

roles/container-engine/containerd-common/tasks/main.yml

@@ -2,9 +2,9 @@
 - name: Containerd-common | check if fedora coreos
   stat:
     path: /run/ostree-booted
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: ostree
 
 - name: Containerd-common | set is_ostree

roles/container-engine/containerd/handlers/main.yml

@@ -3,9 +3,9 @@
   systemd_service:
     name: containerd
     state: restarted
-    enabled: yes
-    daemon-reload: yes
-    masked: no
+    enabled: true
+    daemon-reload: true
+    masked: false
   listen: Restart containerd
 
 - name: Containerd | wait for containerd

roles/container-engine/containerd/molecule/default/prepare.yml

 ---
 - name: Prepare
   hosts: all
-  gather_facts: False
+  gather_facts: false
   become: true
   vars:
     ignore_assert_errors: true
@@ -19,7 +19,7 @@
 
 - name: Prepare CNI
   hosts: all
-  gather_facts: False
+  gather_facts: false
   become: true
   vars:
     ignore_assert_errors: true

roles/container-engine/containerd/tasks/main.yml

@@ -36,7 +36,7 @@
     src: "{{ downloads.containerd.dest }}"
     dest: "{{ containerd_bin_dir }}"
     mode: "0755"
-    remote_src: yes
+    remote_src: true
     extra_opts:
       - --strip-components=1
   notify: Restart containerd
@@ -138,6 +138,6 @@
 - name: Containerd | Ensure containerd is started and enabled
   systemd_service:
     name: containerd
-    daemon_reload: yes
-    enabled: yes
+    daemon_reload: true
+    enabled: true
     state: started

roles/container-engine/cri-dockerd/handlers/main.yml

@@ -3,7 +3,7 @@
   systemd_service:
     name: cri-dockerd
     daemon_reload: true
-    masked: no
+    masked: false
   listen: Restart and enable cri-dockerd
 
 - name: Cri-dockerd | restart docker.service
@@ -27,5 +27,5 @@
 - name: Cri-dockerd | enable cri-dockerd service
   service:
     name: cri-dockerd.service
-    enabled: yes
+    enabled: true
   listen: Restart and enable cri-dockerd

roles/container-engine/cri-o/handlers/main.yml

@@ -8,5 +8,5 @@
   service:
     name: crio
     state: restarted
-    enabled: yes
+    enabled: true
   listen: Restart crio

roles/container-engine/cri-o/molecule/default/prepare.yml

 ---
 - name: Prepare
   hosts: all
-  gather_facts: False
+  gather_facts: false
   become: true
   vars:
     ignore_assert_errors: true
@@ -19,7 +19,7 @@
 
 - name: Prepare CNI
   hosts: all
-  gather_facts: False
+  gather_facts: false
   become: true
   vars:
     ignore_assert_errors: true

roles/container-engine/cri-o/tasks/main.yaml

@@ -5,9 +5,9 @@
 - name: Cri-o | check if fedora coreos
   stat:
     path: /run/ostree-booted
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: ostree
 
 - name: Cri-o | set is_ostree

roles/container-engine/cri-o/tasks/setup-amazon.yaml

@@ -8,7 +8,7 @@
   lineinfile:
     dest: /etc/yum.repos.d/amzn2-extras.repo
     line: "[amzn2extra-docker]"
-  check_mode: yes
+  check_mode: true
   register: amzn2_extras_docker_repo
   when:
     - amzn2_extras_file_stat.stat.exists
@@ -19,7 +19,7 @@
     section: amzn2extra-docker
     option: enabled
     value: "0"
-    backup: yes
+    backup: true
     mode: "0644"
   when:
     - amzn2_extras_file_stat.stat.exists

roles/container-engine/crictl/handlers/main.yml

 ---
 - name: Get crictl completion
   command: "{{ bin_dir }}/crictl completion"
-  changed_when: False
+  changed_when: false
   register: cri_completion
   check_mode: false
 

roles/container-engine/docker-storage/tasks/main.yml

@@ -39,7 +39,7 @@
     state: present
 
 - name: Docker-storage-setup | install and run container-storage-setup
-  become: yes
+  become: true
   script: |
     install_container_storage_setup.sh \
       {{ docker_container_storage_setup_repository }} \

roles/container-engine/docker/handlers/main.yml

@@ -3,7 +3,7 @@
   systemd_service:
     name: docker
     daemon_reload: true
-    masked: no
+    masked: false
   listen: Restart docker
 
 - name: Docker | reload docker.socket

roles/container-engine/docker/tasks/main.yml

@@ -2,9 +2,9 @@
 - name: Check if fedora coreos
   stat:
     path: /run/ostree-booted
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: ostree
 
 - name: Set is_ostree
@@ -66,7 +66,7 @@
     path: /etc/apt/sources.list
     regexp: 'buster-backports'
     state: absent
-    backup: yes
+    backup: true
   when:
     - ansible_os_family == 'Debian'
     - ansible_distribution_release == "buster"
@@ -183,7 +183,7 @@
 - name: Ensure docker service is started and enabled
   service:
     name: "{{ item }}"
-    enabled: yes
+    enabled: true
     state: started
   with_items:
     - docker

roles/container-engine/docker/tasks/set_facts_dns.yml

@@ -21,9 +21,9 @@
   shell: set -o pipefail && grep "^nameserver" /etc/resolv.conf | sed -r 's/^nameserver\s*([^#\s]+)\s*(#.*)?/\1/'
   args:
     executable: /bin/bash
-  changed_when: False
+  changed_when: false
   register: system_nameservers
-  check_mode: no
+  check_mode: false
 
 - name: Check system search domains
   # noqa risky-shell-pipe - if resolf.conf has no search domain, grep will exit 1 which would force us to add failed_when: false
@@ -31,9 +31,9 @@
   shell: grep "^search" /etc/resolv.conf | sed -r 's/^search\s*([^#]+)\s*(#.*)?/\1/'
   args:
     executable: /bin/bash
-  changed_when: False
+  changed_when: false
   register: system_search_domains
-  check_mode: no
+  check_mode: false
 
 - name: Add system nameservers to docker options
   set_fact:

roles/container-engine/gvisor/tasks/main.yml

@@ -14,7 +14,7 @@
     src: "{{ item.src }}"
     dest: "{{ bin_dir }}/{{ item.dest }}"
     mode: "0755"
-    remote_src: yes
+    remote_src: true
   with_items:
     - { src: "{{ downloads.gvisor_runsc.dest }}", dest: "runsc" }
     - { src: "{{ downloads.gvisor_containerd_shim.dest }}", dest: "containerd-shim-runsc-v1" }

roles/container-engine/kata-containers/tasks/main.yml

@@ -11,7 +11,7 @@
     mode: "0755"
     owner: root
     group: root
-    remote_src: yes
+    remote_src: true
 
 - name: Kata-containers | Create config directory
   file:

roles/container-engine/nerdctl/handlers/main.yml

 ---
 - name: Get nerdctl completion
   command: "{{ bin_dir }}/nerdctl completion bash"
-  changed_when: False
+  changed_when: false
   register: nerdctl_completion
   check_mode: false
 

roles/container-engine/runc/tasks/main.yml

@@ -2,9 +2,9 @@
 - name: Runc | check if fedora coreos
   stat:
     path: /run/ostree-booted
-    get_attributes: no
-    get_checksum: no
-    get_mime: no
+    get_attributes: false
+    get_checksum: false
+    get_mime: false
   register: ostree
 
 - name: Runc | set is_ostree