From ad1ce92b41b646f43213fb168ae441b59dcfb2b3 Mon Sep 17 00:00:00 2001
From: Mohamed Omar Zaian <1049820+mzaian@users.noreply.github.com>
Date: Mon, 19 Aug 2024 14:59:30 +0200
Subject: [PATCH] Update node-feature-discovery to v0.16.4 (#11250)
---
README.md | 2 +-
.../templates/nfd-api-crds.yaml.j2 | 525 +++++++++++++++---
.../templates/nfd-clusterrole.yaml.j2 | 8 +
.../templates/nfd-master.yaml.j2 | 14 +-
.../templates/nfd-role.yaml.j2 | 6 +
.../defaults/main/download.yml | 2 +-
6 files changed, 458 insertions(+), 99 deletions(-)
diff --git a/README.md b/README.md
index b4cb4147d..2f43f68fe 100644
--- a/README.md
+++ b/README.md
@@ -193,7 +193,7 @@ Note: Upstart/SysV init based OS types are not supported.
- [gcp-pd-csi-plugin](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver) v1.9.2
- [local-path-provisioner](https://github.com/rancher/local-path-provisioner) v0.0.24
- [local-volume-provisioner](https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner) v2.5.0
- - [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) v0.14.2
+ - [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) v0.16.4
## Container Runtime Notes
diff --git a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-api-crds.yaml.j2 b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-api-crds.yaml.j2
index 6866c7ffe..0a73c5dca 100644
--- a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-api-crds.yaml.j2
+++ b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-api-crds.yaml.j2
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.12.1
+ controller-gen.kubebuilder.io/version: v0.14.0
name: nodefeatures.nfd.k8s-sigs.io
spec:
group: nfd.k8s-sigs.io
@@ -17,23 +17,30 @@ spec:
- name: v1alpha1
schema:
openAPIV3Schema:
- description: NodeFeature resource holds the features discovered for one node
- in the cluster.
+ description: |-
+ NodeFeature resource holds the features discovered for one node in the
+ cluster.
properties:
apiVersion:
- description: 'APIVersion defines the versioned schema of this representation
- of an object. Servers should convert recognized schemas to the latest
- internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ description: |-
+ APIVersion defines the versioned schema of this representation of an object.
+ Servers should convert recognized schemas to the latest internal value, and
+ may reject unrecognized values.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
- description: 'Kind is a string value representing the REST resource this
- object represents. Servers may infer this from the endpoint the client
- submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+ description: |-
+ Kind is a string value representing the REST resource this object represents.
+ Servers may infer this from the endpoint the client submits requests to.
+ Cannot be updated.
+ In CamelCase.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
spec:
- description: NodeFeatureSpec describes a NodeFeature object.
+ description: Specification of the NodeFeature, containing features discovered
+ for a node.
properties:
features:
description: Features is the full "raw" features data that has been
@@ -47,6 +54,7 @@ spec:
elements:
additionalProperties:
type: string
+ description: Individual features of the feature set.
type: object
required:
- elements
@@ -64,6 +72,7 @@ spec:
description: Nil is a dummy empty struct for protobuf
compatibility
type: object
+ description: Individual features of the feature set.
type: object
required:
- elements
@@ -77,6 +86,7 @@ spec:
which is an instance having multiple attributes.
properties:
elements:
+ description: Individual features of the feature set.
items:
description: InstanceFeature represents one instance of
a complex features, e.g. a device.
@@ -84,6 +94,7 @@ spec:
attributes:
additionalProperties:
type: string
+ description: Attributes of the instance feature.
type: object
required:
- attributes
@@ -113,7 +124,278 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.12.1
+ controller-gen.kubebuilder.io/version: v0.14.0
+ name: nodefeaturegroups.nfd.k8s-sigs.io
+spec:
+ group: nfd.k8s-sigs.io
+ names:
+ kind: NodeFeatureGroup
+ listKind: NodeFeatureGroupList
+ plural: nodefeaturegroups
+ shortNames:
+ - nfg
+ singular: nodefeaturegroup
+ scope: Namespaced
+ versions:
+ - name: v1alpha1
+ schema:
+ openAPIV3Schema:
+ description: NodeFeatureGroup resource holds Node pools by featureGroup
+ properties:
+ apiVersion:
+ description: |-
+ APIVersion defines the versioned schema of this representation of an object.
+ Servers should convert recognized schemas to the latest internal value, and
+ may reject unrecognized values.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
+ type: string
+ kind:
+ description: |-
+ Kind is a string value representing the REST resource this object represents.
+ Servers may infer this from the endpoint the client submits requests to.
+ Cannot be updated.
+ In CamelCase.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
+ type: string
+ metadata:
+ type: object
+ spec:
+ description: Spec defines the rules to be evaluated.
+ properties:
+ featureGroupRules:
+ description: List of rules to evaluate to determine nodes that belong
+ in this group.
+ items:
+ description: GroupRule defines a rule for nodegroup filtering.
+ properties:
+ matchAny:
+ description: MatchAny specifies a list of matchers one of which
+ must match.
+ items:
+ description: MatchAnyElem specifies one sub-matcher of MatchAny.
+ properties:
+ matchFeatures:
+ description: MatchFeatures specifies a set of matcher
+ terms all of which must match.
+ items:
+ description: |-
+ FeatureMatcherTerm defines requirements against one feature set. All
+ requirements (specified as MatchExpressions) are evaluated against each
+ element in the feature set.
+ properties:
+ feature:
+ description: Feature is the name of the feature
+ set to match against.
+ type: string
+ matchExpressions:
+ additionalProperties:
+ description: |-
+ MatchExpression specifies an expression to evaluate against a set of input
+ values. It contains an operator that is applied when matching the input and
+ an array of values that the operator evaluates the input against.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
+ type: object
+ description: |-
+ MatchExpressions is the set of per-element expressions evaluated. These
+ match against the value of the specified elements.
+ type: object
+ matchName:
+ description: |-
+ MatchName in an expression that is matched against the name of each
+ element in the feature set.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
+ type: object
+ required:
+ - feature
+ type: object
+ type: array
+ required:
+ - matchFeatures
+ type: object
+ type: array
+ matchFeatures:
+ description: MatchFeatures specifies a set of matcher terms
+ all of which must match.
+ items:
+ description: |-
+ FeatureMatcherTerm defines requirements against one feature set. All
+ requirements (specified as MatchExpressions) are evaluated against each
+ element in the feature set.
+ properties:
+ feature:
+ description: Feature is the name of the feature set to
+ match against.
+ type: string
+ matchExpressions:
+ additionalProperties:
+ description: |-
+ MatchExpression specifies an expression to evaluate against a set of input
+ values. It contains an operator that is applied when matching the input and
+ an array of values that the operator evaluates the input against.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
+ type: object
+ description: |-
+ MatchExpressions is the set of per-element expressions evaluated. These
+ match against the value of the specified elements.
+ type: object
+ matchName:
+ description: |-
+ MatchName in an expression that is matched against the name of each
+ element in the feature set.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
+ type: object
+ required:
+ - feature
+ type: object
+ type: array
+ name:
+ description: Name of the rule.
+ type: string
+ required:
+ - name
+ type: object
+ type: array
+ required:
+ - featureGroupRules
+ type: object
+ status:
+ description: |-
+ Status of the NodeFeatureGroup after the most recent evaluation of the
+ specification.
+ properties:
+ nodes:
+ description: Nodes is a list of FeatureGroupNode in the cluster that
+ match the featureGroupRules
+ items:
+ properties:
+ name:
+ description: Name of the node.
+ type: string
+ required:
+ - name
+ type: object
+ type: array
+ x-kubernetes-list-map-keys:
+ - name
+ x-kubernetes-list-type: map
+ type: object
+ required:
+ - spec
+ type: object
+ served: true
+ storage: true
+ subresources:
+ status: {}
+---
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+ annotations:
+ controller-gen.kubebuilder.io/version: v0.14.0
name: nodefeaturerules.nfd.k8s-sigs.io
spec:
group: nfd.k8s-sigs.io
@@ -129,23 +411,29 @@ spec:
- name: v1alpha1
schema:
openAPIV3Schema:
- description: NodeFeatureRule resource specifies a configuration for feature-based
+ description: |-
+ NodeFeatureRule resource specifies a configuration for feature-based
customization of node objects, such as node labeling.
properties:
apiVersion:
- description: 'APIVersion defines the versioned schema of this representation
- of an object. Servers should convert recognized schemas to the latest
- internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
+ description: |-
+ APIVersion defines the versioned schema of this representation of an object.
+ Servers should convert recognized schemas to the latest internal value, and
+ may reject unrecognized values.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
- description: 'Kind is a string value representing the REST resource this
- object represents. Servers may infer this from the endpoint the client
- submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
+ description: |-
+ Kind is a string value representing the REST resource this object represents.
+ Servers may infer this from the endpoint the client submits requests to.
+ Cannot be updated.
+ In CamelCase.
+ More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
spec:
- description: NodeFeatureRuleSpec describes a NodeFeatureRule.
+ description: Spec defines the rules to be evaluated.
properties:
rules:
description: Rules is a list of node customization rules.
@@ -153,6 +441,11 @@ spec:
description: Rule defines a rule for node customization such as
labeling.
properties:
+ annotations:
+ additionalProperties:
+ type: string
+ description: Annotations to create if the rule matches.
+ type: object
extendedResources:
additionalProperties:
type: string
@@ -164,10 +457,10 @@ spec:
description: Labels to create if the rule matches.
type: object
labelsTemplate:
- description: LabelsTemplate specifies a template to expand for
- dynamically generating multiple labels. Data (after template
- expansion) must be keys with an optional value (<key>[=<value>])
- separated by newlines.
+ description: |-
+ LabelsTemplate specifies a template to expand for dynamically generating
+ multiple labels. Data (after template expansion) must be keys with an
+ optional value (<key>[=<value>]) separated by newlines.
type: string
matchAny:
description: MatchAny specifies a list of matchers one of which
@@ -179,25 +472,21 @@ spec:
description: MatchFeatures specifies a set of matcher
terms all of which must match.
items:
- description: FeatureMatcherTerm defines requirements
- against one feature set. All requirements (specified
- as MatchExpressions) are evaluated against each element
- in the feature set.
+ description: |-
+ FeatureMatcherTerm defines requirements against one feature set. All
+ requirements (specified as MatchExpressions) are evaluated against each
+ element in the feature set.
properties:
feature:
+ description: Feature is the name of the feature
+ set to match against.
type: string
matchExpressions:
additionalProperties:
- description: "MatchExpression specifies an expression
- to evaluate against a set of input values. It
- contains an operator that is applied when matching
- the input and an array of values that the operator
- evaluates the input against. \n NB: CreateMatchExpression
- or MustCreateMatchExpression() should be used
- for creating new instances. \n NB: Validate()
- must be called if Op or Value fields are modified
- or if a new instance is created from scratch
- without using the helper functions."
+ description: |-
+ MatchExpression specifies an expression to evaluate against a set of input
+ values. It contains an operator that is applied when matching the input and
+ an array of values that the operator evaluates the input against.
properties:
op:
description: Op is the operator to be applied.
@@ -214,28 +503,56 @@ spec:
- IsFalse
type: string
value:
- description: Value is the list of values that
- the operand evaluates the input against.
- Value should be empty if the operator is
- Exists, DoesNotExist, IsTrue or IsFalse.
- Value should contain exactly one element
- if the operator is Gt or Lt and exactly
- two elements if the operator is GtLt. In
- other cases Value should contain at least
- one element.
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
items:
type: string
type: array
required:
- op
type: object
- description: MatchExpressionSet contains a set of
- MatchExpressions, each of which is evaluated against
- a set of input values.
+ description: |-
+ MatchExpressions is the set of per-element expressions evaluated. These
+ match against the value of the specified elements.
+ type: object
+ matchName:
+ description: |-
+ MatchName in an expression that is matched against the name of each
+ element in the feature set.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
type: object
required:
- feature
- - matchExpressions
type: object
type: array
required:
@@ -246,23 +563,21 @@ spec:
description: MatchFeatures specifies a set of matcher terms
all of which must match.
items:
- description: FeatureMatcherTerm defines requirements against
- one feature set. All requirements (specified as MatchExpressions)
- are evaluated against each element in the feature set.
+ description: |-
+ FeatureMatcherTerm defines requirements against one feature set. All
+ requirements (specified as MatchExpressions) are evaluated against each
+ element in the feature set.
properties:
feature:
+ description: Feature is the name of the feature set to
+ match against.
type: string
matchExpressions:
additionalProperties:
- description: "MatchExpression specifies an expression
- to evaluate against a set of input values. It contains
- an operator that is applied when matching the input
- and an array of values that the operator evaluates
- the input against. \n NB: CreateMatchExpression or
- MustCreateMatchExpression() should be used for creating
- new instances. \n NB: Validate() must be called if
- Op or Value fields are modified or if a new instance
- is created from scratch without using the helper functions."
+ description: |-
+ MatchExpression specifies an expression to evaluate against a set of input
+ values. It contains an operator that is applied when matching the input and
+ an array of values that the operator evaluates the input against.
properties:
op:
description: Op is the operator to be applied.
@@ -279,25 +594,56 @@ spec:
- IsFalse
type: string
value:
- description: Value is the list of values that the
- operand evaluates the input against. Value should
- be empty if the operator is Exists, DoesNotExist,
- IsTrue or IsFalse. Value should contain exactly
- one element if the operator is Gt or Lt and exactly
- two elements if the operator is GtLt. In other
- cases Value should contain at least one element.
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
items:
type: string
type: array
required:
- op
type: object
- description: MatchExpressionSet contains a set of MatchExpressions,
- each of which is evaluated against a set of input values.
+ description: |-
+ MatchExpressions is the set of per-element expressions evaluated. These
+ match against the value of the specified elements.
+ type: object
+ matchName:
+ description: |-
+ MatchName in an expression that is matched against the name of each
+ element in the feature set.
+ properties:
+ op:
+ description: Op is the operator to be applied.
+ enum:
+ - In
+ - NotIn
+ - InRegexp
+ - Exists
+ - DoesNotExist
+ - Gt
+ - Lt
+ - GtLt
+ - IsTrue
+ - IsFalse
+ type: string
+ value:
+ description: |-
+ Value is the list of values that the operand evaluates the input
+ against. Value should be empty if the operator is Exists, DoesNotExist,
+ IsTrue or IsFalse. Value should contain exactly one element if the
+ operator is Gt or Lt and exactly two elements if the operator is GtLt.
+ In other cases Value should contain at least one element.
+ items:
+ type: string
+ type: array
+ required:
+ - op
type: object
required:
- feature
- - matchExpressions
type: object
type: array
name:
@@ -306,21 +652,24 @@ spec:
taints:
description: Taints to create if the rule matches.
items:
- description: The node this Taint is attached to has the "effect"
- on any pod that does not tolerate the Taint.
+ description: |-
+ The node this Taint is attached to has the "effect" on
+ any pod that does not tolerate the Taint.
properties:
effect:
- description: Required. The effect of the taint on pods
- that do not tolerate the taint. Valid effects are NoSchedule,
- PreferNoSchedule and NoExecute.
+ description: |-
+ Required. The effect of the taint on pods
+ that do not tolerate the taint.
+ Valid effects are NoSchedule, PreferNoSchedule and NoExecute.
type: string
key:
description: Required. The taint key to be applied to
a node.
type: string
timeAdded:
- description: TimeAdded represents the time at which the
- taint was added. It is only written for NoExecute taints.
+ description: |-
+ TimeAdded represents the time at which the taint was added.
+ It is only written for NoExecute taints.
format: date-time
type: string
value:
@@ -335,17 +684,17 @@ spec:
vars:
additionalProperties:
type: string
- description: Vars is the variables to store if the rule matches.
- Variables do not directly inflict any changes in the node
- object. However, they can be referenced from other rules enabling
- more complex rule hierarchies, without exposing intermediary
- output values as labels.
+ description: |-
+ Vars is the variables to store if the rule matches. Variables do not
+ directly inflict any changes in the node object. However, they can be
+ referenced from other rules enabling more complex rule hierarchies,
+ without exposing intermediary output values as labels.
type: object
varsTemplate:
- description: VarsTemplate specifies a template to expand for
- dynamically generating multiple variables. Data (after template
- expansion) must be keys with an optional value (<key>[=<value>])
- separated by newlines.
+ description: |-
+ VarsTemplate specifies a template to expand for dynamically generating
+ multiple variables. Data (after template expansion) must be keys with an
+ optional value (<key>[=<value>]) separated by newlines.
type: string
required:
- name
diff --git a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-clusterrole.yaml.j2 b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-clusterrole.yaml.j2
index ce880d86e..328b3e660 100644
--- a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-clusterrole.yaml.j2
+++ b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-clusterrole.yaml.j2
@@ -18,10 +18,18 @@ rules:
resources:
- nodefeatures
- nodefeaturerules
+ - nodefeaturegroups
verbs:
- get
- list
- watch
+- apiGroups:
+ - nfd.k8s-sigs.io
+ resources:
+ - nodefeaturegroup/status
+ verbs:
+ - patch
+ - update
- apiGroups:
- coordination.k8s.io
resources:
diff --git a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-master.yaml.j2 b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-master.yaml.j2
index 348673014..c4aacefd8 100644
--- a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-master.yaml.j2
+++ b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-master.yaml.j2
@@ -33,22 +33,18 @@ spec:
image: {{ node_feature_discovery_image_repo }}:{{ node_feature_discovery_image_tag }}
imagePullPolicy: IfNotPresent
livenessProbe:
- exec:
- command:
- - "/usr/bin/grpc_health_probe"
- - "-addr=:8080"
+ grpc:
+ port: 8082
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe:
- exec:
- command:
- - "/usr/bin/grpc_health_probe"
- - "-addr=:8080"
+ grpc:
+ port: 8082
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
ports:
- - containerPort: 8080
+ - containerPort: 8082
name: grpc
- containerPort: 8081
name: metrics
diff --git a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-role.yaml.j2 b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-role.yaml.j2
index 628134598..074e39bde 100644
--- a/roles/kubernetes-apps/node_feature_discovery/templates/nfd-role.yaml.j2
+++ b/roles/kubernetes-apps/node_feature_discovery/templates/nfd-role.yaml.j2
@@ -12,3 +12,9 @@ rules:
- create
- get
- update
+- apiGroups:
+ - ""
+ resources:
+ - pods
+ verbs:
+ - get
diff --git a/roles/kubespray-defaults/defaults/main/download.yml b/roles/kubespray-defaults/defaults/main/download.yml
index b32467e34..951db359a 100644
--- a/roles/kubespray-defaults/defaults/main/download.yml
+++ b/roles/kubespray-defaults/defaults/main/download.yml
@@ -409,7 +409,7 @@ metallb_speaker_image_repo: "{{ quay_image_repo }}/metallb/speaker"
metallb_controller_image_repo: "{{ quay_image_repo }}/metallb/controller"
metallb_version: v0.13.9
-node_feature_discovery_version: v0.14.2
+node_feature_discovery_version: v0.16.4
node_feature_discovery_image_repo: "{{ kube_image_repo }}/nfd/node-feature-discovery"
node_feature_discovery_image_tag: "{{ node_feature_discovery_version }}"
--
GitLab