From b4e2b85745046c4b120982b8234d23da869eebef Mon Sep 17 00:00:00 2001 From: Erwan Miran <mirwan@users.noreply.github.com> Date: Tue, 16 Oct 2018 08:48:12 +0200 Subject: [PATCH] Replace shell with command in order to allow the task to fail when openssl x509 does return zero (#3516) --- roles/etcd/tasks/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/roles/etcd/tasks/main.yml b/roles/etcd/tasks/main.yml index db59a983f..0ce11d355 100644 --- a/roles/etcd/tasks/main.yml +++ b/roles/etcd/tasks/main.yml @@ -14,7 +14,7 @@ - etcd-secrets - name: "Gen_certs | Get etcd certificate serials" - shell: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial | cut -d= -f2" + command: "openssl x509 -in {{ etcd_cert_dir }}/node-{{ inventory_hostname }}.pem -noout -serial" register: "etcd_client_cert_serial_result" changed_when: false when: inventory_hostname in groups['k8s-cluster']|union(groups['etcd'])|union(groups['calico-rr']|default([]))|unique|sort @@ -24,7 +24,7 @@ - name: Set etcd_client_cert_serial set_fact: - etcd_client_cert_serial: "{{ etcd_client_cert_serial_result.stdout }}" + etcd_client_cert_serial: "{{ etcd_client_cert_serial_result.stdout.split('=')[1] }}" when: inventory_hostname in groups['k8s-cluster']|union(groups['etcd'])|union(groups['calico-rr']|default([]))|unique|sort tags: - master -- GitLab