Skip to content
Snippets Groups Projects
Commit 35d133fc authored by Thomas Woerner's avatar Thomas Woerner
Browse files

test_group_membermanager.yml: Use result.failed also for failed_when

For failed_when result.failed should be used to make sure that
the task fails if there was an error.
parent c7e54628
No related branches found
No related tags found
No related merge requests found
...@@ -32,28 +32,28 @@ ...@@ -32,28 +32,28 @@
first: manageruser2 first: manageruser2
last: Last2 last: Last2
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure testgroup is present - name: Ensure testgroup is present
ipagroup: ipagroup:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
name: testgroup name: testgroup
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure managergroup1 is present - name: Ensure managergroup1 is present
ipagroup: ipagroup:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
name: managergroup1 name: managergroup1
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure managergroup2 is present - name: Ensure managergroup2 is present
ipagroup: ipagroup:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
name: managergroup2 name: managergroup2
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user1 is present for testgroup - name: Ensure membermanager user1 is present for testgroup
ipagroup: ipagroup:
...@@ -61,7 +61,7 @@ ...@@ -61,7 +61,7 @@
name: testgroup name: testgroup
membermanager_user: manageruser1 membermanager_user: manageruser1
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user1 is present for testgroup again - name: Ensure membermanager user1 is present for testgroup again
ipagroup: ipagroup:
...@@ -69,7 +69,7 @@ ...@@ -69,7 +69,7 @@
name: testgroup name: testgroup
membermanager_user: manageruser1 membermanager_user: manageruser1
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager group1 is present for testgroup - name: Ensure membermanager group1 is present for testgroup
ipagroup: ipagroup:
...@@ -77,7 +77,7 @@ ...@@ -77,7 +77,7 @@
name: testgroup name: testgroup
membermanager_group: managergroup1 membermanager_group: managergroup1
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager group1 is present for testgroup again - name: Ensure membermanager group1 is present for testgroup again
ipagroup: ipagroup:
...@@ -85,7 +85,7 @@ ...@@ -85,7 +85,7 @@
name: testgroup name: testgroup
membermanager_group: managergroup1 membermanager_group: managergroup1
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager user2 and group2 members are present for testgroup - name: Ensure membermanager user2 and group2 members are present for testgroup
ipagroup: ipagroup:
...@@ -95,7 +95,7 @@ ...@@ -95,7 +95,7 @@
membermanager_group: managergroup2 membermanager_group: managergroup2
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user2 and group2 members are present for testgroup again - name: Ensure membermanager user2 and group2 members are present for testgroup again
ipagroup: ipagroup:
...@@ -105,7 +105,7 @@ ...@@ -105,7 +105,7 @@
membermanager_group: managergroup2 membermanager_group: managergroup2
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager user and group members are present for testgroup again - name: Ensure membermanager user and group members are present for testgroup again
ipagroup: ipagroup:
...@@ -115,7 +115,7 @@ ...@@ -115,7 +115,7 @@
membermanager_group: managergroup1,managergroup2 membermanager_group: managergroup1,managergroup2
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager user1 and group1 members are absent for testgroup - name: Ensure membermanager user1 and group1 members are absent for testgroup
ipagroup: ipagroup:
...@@ -126,7 +126,7 @@ ...@@ -126,7 +126,7 @@
action: member action: member
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user1 and group1 members are absent for testgroup again - name: Ensure membermanager user1 and group1 members are absent for testgroup again
ipagroup: ipagroup:
...@@ -137,7 +137,7 @@ ...@@ -137,7 +137,7 @@
action: member action: member
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager user1 and group1 members are present for testgroup - name: Ensure membermanager user1 and group1 members are present for testgroup
ipagroup: ipagroup:
...@@ -147,7 +147,7 @@ ...@@ -147,7 +147,7 @@
membermanager_group: managergroup1 membermanager_group: managergroup1
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user1 and group1 members are present for testgroup again - name: Ensure membermanager user1 and group1 members are present for testgroup again
ipagroup: ipagroup:
...@@ -157,7 +157,7 @@ ...@@ -157,7 +157,7 @@
membermanager_group: managergroup1 membermanager_group: managergroup1
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure membermanager user and group members are absent for testgroup - name: Ensure membermanager user and group members are absent for testgroup
ipagroup: ipagroup:
...@@ -168,7 +168,7 @@ ...@@ -168,7 +168,7 @@
action: member action: member
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure membermanager user and group members are absent for testgroup again - name: Ensure membermanager user and group members are absent for testgroup again
ipagroup: ipagroup:
...@@ -179,7 +179,7 @@ ...@@ -179,7 +179,7 @@
action: member action: member
state: absent state: absent
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: Ensure user manangeruser1 and manageruser2 is absent - name: Ensure user manangeruser1 and manageruser2 is absent
ipauser: ipauser:
...@@ -187,7 +187,7 @@ ...@@ -187,7 +187,7 @@
name: manageruser1,manageruser2 name: manageruser1,manageruser2
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure unknown membermanager_user member failure - name: Ensure unknown membermanager_user member failure
ipagroup: ipagroup:
...@@ -196,7 +196,7 @@ ...@@ -196,7 +196,7 @@
membermanager_user: unknown_user membermanager_user: unknown_user
action: member action: member
register: result register: result
failed_when: result.changed or "no such entry" not in result.msg failed_when: result.changed or "no such entry" not in result.msg or not result.failed
- name: Ensure group testgroup, managergroup1 and managergroup2 are absent - name: Ensure group testgroup, managergroup1 and managergroup2 are absent
ipagroup: ipagroup:
...@@ -204,6 +204,6 @@ ...@@ -204,6 +204,6 @@
name: testgroup,managergroup1,managergroup2 name: testgroup,managergroup1,managergroup2
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
when: ipa_version is version('4.8.4', '>=') when: ipa_version is version('4.8.4', '>=')
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment