Skip to content
Snippets Groups Projects
Commit 47a1d50c authored by Thomas Woerner's avatar Thomas Woerner
Browse files

Fixes for ansible-lint 6.22.1

- Replace outdated noqa 503 with noqa no-handler
- Drop outdated and not needed noqa 505 for include_vars
- Drop outdated noqa deprecated-command-syntax for
  ansible.builtin.shell using cmd tag

These warnings have been reported by utils/lint_check.sh using
ansible-lint 6.22.1.
parent 3a304e8b
No related branches found
No related tags found
No related merge requests found
Showing
with 20 additions and 19 deletions
---
- name: Certificate manage example - name: Certificate manage example
hosts: ipaserver hosts: ipaserver
become: false become: false
......
...@@ -30,7 +30,7 @@ ...@@ -30,7 +30,7 @@
check_mode: yes check_mode: yes
register: sid_disabled register: sid_disabled
- name: Ensure netbios_name can't be changed without SID enabled. # noqa 503 - name: Ensure netbios_name can't be changed without SID enabled. # noqa no-handler
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
ipaapi_context: "{{ ipa_context | default(omit) }}" ipaapi_context: "{{ ipa_context | default(omit) }}"
...@@ -39,7 +39,7 @@ ...@@ -39,7 +39,7 @@
failed_when: not result.failed and "SID generation must be enabled" in result.msg failed_when: not result.failed and "SID generation must be enabled" in result.msg
when: sid_disabled.changed when: sid_disabled.changed
- name: Ensure SIDs can't be changed without SID enabled. # noqa 503 - name: Ensure SIDs can't be changed without SID enabled. # noqa no-handler
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
ipaapi_context: "{{ ipa_context | default(omit) }}" ipaapi_context: "{{ ipa_context | default(omit) }}"
......
...@@ -1549,7 +1549,7 @@ ...@@ -1549,7 +1549,7 @@
- name: Cleanup test environment. - name: Cleanup test environment.
ansible.builtin.include_tasks: env_cleanup.yml ansible.builtin.include_tasks: env_cleanup.yml
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" ansible.builtin.shell: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1] with_items: [1]
become: no become: no
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
tasks: tasks:
- name: Include groups.json - name: Include groups.json
ansible.builtin.include_vars: ansible.builtin.include_vars:
file: groups.json # noqa 505 file: groups.json
- name: Initialize groups_names - name: Initialize groups_names
ansible.builtin.set_fact: ansible.builtin.set_fact:
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
tasks: tasks:
- name: Include groups.json - name: Include groups.json
ansible.builtin.include_vars: ansible.builtin.include_vars:
file: groups.json # noqa 505 file: groups.json
- name: Groups present len:{{ group_list | length }} - name: Groups present len:{{ group_list | length }}
ipagroup: ipagroup:
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
tasks: tasks:
- name: Include groups.json - name: Include groups.json
ansible.builtin.include_vars: ansible.builtin.include_vars:
file: groups.json # noqa 505 file: groups.json
- name: Size of groups slice. - name: Size of groups slice.
ansible.builtin.debug: ansible.builtin.debug:
......
...@@ -99,7 +99,7 @@ ...@@ -99,7 +99,7 @@
register: result register: result
failed_when: result.changed or result.failed failed_when: result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -98,7 +98,7 @@ ...@@ -98,7 +98,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -558,7 +558,7 @@ ...@@ -558,7 +558,7 @@
name: test_idview name: test_idview
state: absent state: absent
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -214,7 +214,7 @@ ...@@ -214,7 +214,7 @@
update_dns: yes update_dns: yes
state: absent state: absent
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2] with_items: [1, 2]
......
...@@ -192,7 +192,7 @@ ...@@ -192,7 +192,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -306,7 +306,7 @@ ...@@ -306,7 +306,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [11, 12, 13, 21, 22, 23, 31, 32, 33] with_items: [11, 12, 13, 21, 22, 23, 31, 32, 33]
......
...@@ -100,7 +100,7 @@ ...@@ -100,7 +100,7 @@
- name: Destroy Kerberos tickets. - name: Destroy Kerberos tickets.
ansible.builtin.shell: kdestroy -A -q -c ${KRB5CCNAME} ansible.builtin.shell: kdestroy -A -q -c ${KRB5CCNAME}
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1] with_items: [1]
......
...@@ -80,7 +80,7 @@ ...@@ -80,7 +80,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -93,7 +93,7 @@ ...@@ -93,7 +93,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -225,7 +225,7 @@ ...@@ -225,7 +225,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -161,7 +161,7 @@ ...@@ -161,7 +161,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
......
...@@ -54,7 +54,7 @@ ...@@ -54,7 +54,7 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. # noqa: deprecated-command-syntax - name: Remove certificate files.
ansible.builtin.shell: ansible.builtin.shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2] with_items: [1, 2]
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment