Skip to content
Snippets Groups Projects
Commit 52241fe2 authored by Rafael Guterres Jeffman's avatar Rafael Guterres Jeffman
Browse files

pylint: ensure variables are initialized

pylint doesn't know that some functions may terminate execution, like,
AnsibleModule's fail_json, and assume that, depending on the code path,
some variables may not be initialized when used.

This change ensure that variables are always initialized independent of
the code path.
parent f53ca3ad
No related branches found
No related tags found
No related merge requests found
...@@ -450,6 +450,10 @@ def main(): ...@@ -450,6 +450,10 @@ def main():
commands = [] commands = []
for name in names: for name in names:
_type = None
inclusive_add, inclusive_del = [], []
exclusive_add, exclusive_del = [], []
# Make sure automember rule exists # Make sure automember rule exists
res_find = find_automember(ansible_module, name, automember_type) res_find = find_automember(ansible_module, name, automember_type)
...@@ -495,16 +499,12 @@ def main(): ...@@ -495,16 +499,12 @@ def main():
transform_conditions(inclusive), transform_conditions(inclusive),
res_find.get("automemberinclusiveregex", []) res_find.get("automemberinclusiveregex", [])
) )
else:
inclusive_add, inclusive_del = [], []
if exclusive is not None: if exclusive is not None:
exclusive_add, exclusive_del = gen_add_del_lists( exclusive_add, exclusive_del = gen_add_del_lists(
transform_conditions(exclusive), transform_conditions(exclusive),
res_find.get("automemberexclusiveregex", []) res_find.get("automemberexclusiveregex", [])
) )
else:
exclusive_add, exclusive_del = [], []
elif action == "member": elif action == "member":
if res_find is None: if res_find is None:
...@@ -512,9 +512,7 @@ def main(): ...@@ -512,9 +512,7 @@ def main():
msg="No automember '%s'" % name) msg="No automember '%s'" % name)
inclusive_add = transform_conditions(inclusive or []) inclusive_add = transform_conditions(inclusive or [])
inclusive_del = []
exclusive_add = transform_conditions(exclusive or []) exclusive_add = transform_conditions(exclusive or [])
exclusive_del = []
for _inclusive in inclusive_add: for _inclusive in inclusive_add:
key, regex = _inclusive.split("=", 1) key, regex = _inclusive.split("=", 1)
......
...@@ -250,6 +250,8 @@ def main(): ...@@ -250,6 +250,8 @@ def main():
operation = "add" operation = "add"
invalid = [] invalid = []
wants_enable = False
if state in ["enabled", "disabled"]: if state in ["enabled", "disabled"]:
if action == "member": if action == "member":
ansible_module.fail_json( ansible_module.fail_json(
......
...@@ -1605,6 +1605,8 @@ def main(): ...@@ -1605,6 +1605,8 @@ def main():
res_find = find_dnsrecord(ansible_module, zone_name, name) res_find = find_dnsrecord(ansible_module, zone_name, name)
cmds = []
if state == 'present': if state == 'present':
cmds = define_commands_for_present_state( cmds = define_commands_for_present_state(
ansible_module, zone_name, entry, res_find) ansible_module, zone_name, entry, res_find)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment