Skip to content
Snippets Groups Projects
Commit 6601ee3a authored by Rafael Guterres Jeffman's avatar Rafael Guterres Jeffman
Browse files

upstream tests: Removal of 'warn: no' from shell plugins

The parameter 'warn' from ansible.builtin.shell was deprecated in
ansible-core version 2.11 and removed in version 2.14.

This patch removes the usage of this parameter from ansible-freeipa
tests, and adds 'deprecated-command-syntax' to the skip list of
ansible-lint configuration to cope with the change in the linter.
parent 2cfa9af5
No related branches found
No related tags found
No related merge requests found
...@@ -1549,11 +1549,8 @@ ...@@ -1549,11 +1549,8 @@
- name: Cleanup test environment. - name: Cleanup test environment.
include_tasks: env_cleanup.yml include_tasks: env_cleanup.yml
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: ansible.builtin.shell: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1] with_items: [1]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -99,11 +99,9 @@ ...@@ -99,11 +99,9 @@
register: result register: result
failed_when: result.changed or result.failed failed_when: result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -98,11 +98,9 @@ ...@@ -98,11 +98,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -214,11 +214,9 @@ ...@@ -214,11 +214,9 @@
update_dns: yes update_dns: yes
state: absent state: absent
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2] with_items: [1, 2]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -100,11 +100,9 @@ ...@@ -100,11 +100,9 @@
- name: Destroy Kerberos tickets. - name: Destroy Kerberos tickets.
shell: kdestroy -A -q -c ${KRB5CCNAME} shell: kdestroy -A -q -c ${KRB5CCNAME}
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1] with_items: [1]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -80,11 +80,9 @@ ...@@ -80,11 +80,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -93,11 +93,9 @@ ...@@ -93,11 +93,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -225,11 +225,9 @@ ...@@ -225,11 +225,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -161,11 +161,9 @@ ...@@ -161,11 +161,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2, 3] with_items: [1, 2, 3]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
...@@ -54,11 +54,9 @@ ...@@ -54,11 +54,9 @@
register: result register: result
failed_when: not result.changed or result.failed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files. # noqa: deprecated-command-syntax
shell: shell:
cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64" cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
with_items: [1, 2] with_items: [1, 2]
become: no become: no
delegate_to: localhost delegate_to: localhost
args:
warn: no # suppres warning for not using the `file` module.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment